Skip to content

Accept Eigen version 5 as well as 3.4.x. #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timspainNERSC wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −1
Open

Accept Eigen version 5 as well as 3.4.x. #985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f2b12f
Accept Eigen version 5 as well as 3.4.x.
timspainNERSC Nov 11, 2025
d288d54
Remove trailing whitespace.
timspainNERSC Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ if(BUILD_TESTS)
endif()

# Eigen
find_package(Eigen3 3.4 REQUIRED)
find_package(Eigen3 3.4) # Try to find Eigen 3.4
if(NOT TARGET Eigen3::Eigen)
# If Eigen 3.4 was not found, require any Eigen version after 3.4.1 and before 6
find_package(Eigen3 3.4...5 REQUIRED NO_MODULE)
endif()
target_link_libraries(nextsimlib PUBLIC Eigen3::Eigen)

if(DEFINED PYTHON_EXECUTABLE)
Expand Down
Loading