Allow loading filesystems with the recovery bit set #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
changed the title
nicholasbishop
force-pushed
the
bishop-journal-3
branch
5 times, most recently
from
008ceeb to
3db9cf5
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
4 times, most recently
from
7b4bda4 to
f4fab76
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
8 times, most recently
from
ecded87 to
8d74537
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
9 times, most recently
from
7800b72 to
f3386ef
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
3 times, most recently
from
c0ba0a2 to
9e8574a
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
8 times, most recently
from
392e4ca to
2b029b3
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
8 times, most recently
from
b45b6c8 to
0a6f392
Compare
nicholasbishop
changed the title
nicholasbishop
force-pushed
the
bishop-journal-3
branch
from
0a6f392 to
d22c4d7
Compare
nicholasbishop
changed the title
tedbrandston
approved these changes
Feb 26, 2025
| @@ -303,6 +303,8 @@ impl Ext4 { | |||
| }) | |||
There was a problem hiding this comment.
Perhaps as a follow-up: augment this error to make it clear when the block index has been altered by the journal?
There was a problem hiding this comment.
Good idea, filed #436
This fills in the `Journal` struct and implements the rest of the `Journal::load` method.
This is the final step of enabling journal support. Since the test filesystem can now be loaded, this commit also adds some tests.
nicholasbishop
force-pushed
the
bishop-journal-3
branch
from
d22c4d7 to
ed26dab
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step of enabling journal support. Since the test filesystem can now be loaded, this PR also adds some tests.
#317