Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Jacobians only for PEPOLAR by default, allow forcing #3443

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

effigies
Copy link
Member

Builds on #3442.

Closes #3367.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (5566157) to head (039963e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
fmriprep/cli/parser.py 33.33% 2 Missing and 2 partials ⚠️
fmriprep/workflows/base.py 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
- Coverage   72.96%   72.91%   -0.06%     
==========================================
  Files          57       57              
  Lines        4439     4452      +13     
  Branches      572      577       +5     
==========================================
+ Hits         3239     3246       +7     
- Misses       1075     1078       +3     
- Partials      125      128       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies force-pushed the feat/force-fmap-jacobian branch from 8d0822e to 039963e Compare March 24, 2025 16:44
@effigies effigies merged commit 04febd2 into nipreps:master Mar 24, 2025
19 of 21 checks passed
@effigies effigies deleted the feat/force-fmap-jacobian branch March 24, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable fieldmap jacobians by default only for PEPolar fieldmaps
2 participants