Skip to content

ENH: Verify derivatives are compatible with anatomical reference #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Apr 28, 2025

Closes #458

This was partially addressed in #443, but this implementation generalizes across surface reconstruction methods.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 56.29%. Comparing base (91c5fc3) to head (b4f5a58).

Files with missing lines Patch % Lines
nibabies/workflows/anatomical/fit.py 6.25% 15 Missing ⚠️
nibabies/workflows/anatomical/preproc.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   56.46%   56.29%   -0.17%     
==========================================
  Files          70       70              
  Lines        6723     6743      +20     
  Branches      828      830       +2     
==========================================
  Hits         3796     3796              
- Misses       2718     2738      +20     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd
Copy link
Collaborator Author

mgxd commented Apr 29, 2025

@xxnagit would you mind testing this patch to verify it fixes your issue?

https://github.com/nipreps/nibabies/wiki/Testing

@xxnagit
Copy link

xxnagit commented Apr 29, 2025

I have to run this pipeline on HPC, if there is any docker image available, I'm more than happy to try it out. Thank you so much!

@mgxd
Copy link
Collaborator Author

mgxd commented Apr 29, 2025

sure, you can use nipreps/nibabies:derivatives-no-preproc

@xxnagit
Copy link

xxnagit commented Apr 30, 2025

I tried a few more subjects this time as the first time when I reported the bug it was just for one subject. I realized my input are quite different for the orientations, and the outputs of Bibsnet are not uniform due to the consistency with the original input. While when these derivatives are plugged into the infantFS (which requires neurological orientation), it may end up with errors for some cases not the others. This docker image however, can't handle all those variances. In one case with the orientation as aligned with infantFS, I do see the new docker image can tolerate the slight difference between the affine matrix. I'll see if aligning my error cases to the requested orientation can resolve the rest. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --derivatives from Bibsnet precomputed segmentation and mask
2 participants