Skip to content

TST: Provide random data generators to tests #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jhlegarreta
Copy link
Contributor

Provide random data generators to tests.

@jhlegarreta
Copy link
Contributor Author

Cross-ref #71 (comment). A few comments:

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.79%. Comparing base (385dabd) to head (63e6f37).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #85       +/-   ##
===========================================
- Coverage   70.28%   41.79%   -28.50%     
===========================================
  Files          23       23               
  Lines        1060     1060               
  Branches      128      128               
===========================================
- Hits          745      443      -302     
- Misses        271      602      +331     
+ Partials       44       15       -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhlegarreta jhlegarreta force-pushed the ProvideRandomDataGeneratorsToTests branch 2 times, most recently from 3654f0b to 3e6ac7e Compare March 30, 2025 01:55
@jhlegarreta jhlegarreta force-pushed the ProvideRandomDataGeneratorsToTests branch from 3e6ac7e to e0a1187 Compare April 16, 2025 00:06
@jhlegarreta jhlegarreta changed the title ENH: Provide random data generators to tests TST: Provide random data generators to tests Apr 16, 2025
Provide random data generators to tests.

Add the corresponding pytest markers to the `ini_options` section in
`pyproject.toml`.
@jhlegarreta jhlegarreta force-pushed the ProvideRandomDataGeneratorsToTests branch from e0a1187 to 63e6f37 Compare May 31, 2025 19:56
@jhlegarreta jhlegarreta marked this pull request as ready for review May 31, 2025 19:56
@jhlegarreta
Copy link
Contributor Author

Re #85 (comment) let's have this merged in order to make some progress, and I will refactor the necessary parts in a new PR after PR #71 gets merged.

@jhlegarreta jhlegarreta requested a review from oesteban May 31, 2025 19:58
@jhlegarreta
Copy link
Contributor Author

Merging. CI failures are unrelated to these changes (x-ref issue #149).

@jhlegarreta jhlegarreta merged commit 3e608b1 into nipreps:main Jun 1, 2025
28 of 50 checks passed
@jhlegarreta jhlegarreta deleted the ProvideRandomDataGeneratorsToTests branch June 1, 2025 21:07
@oesteban
Copy link
Member

oesteban commented Jun 2, 2025

https://github.com/nipreps/nifreeze/actions/runs/15379441057/job/43268290249#step:11:411 looks like unrelated to #149 and introduced with this PR.

For the time being, I'd suggest not merging PRs failing for #149 and re-trigger them until the stanford dataset goes through.

@oesteban
Copy link
Member

oesteban commented Jun 2, 2025

In fact, the CI failure on this PR (https://github.com/nipreps/nifreeze/actions/runs/15367033028/job/43261539274#step:11:326) is unrelated to #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants