Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workflow arguments for metadata estimates and fallback TRT #479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Member

Follow-up to #477.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.68%. Comparing base (5a55a81) to head (0f3c1de).

Files with missing lines Patch % Lines
sdcflows/workflows/apply/correction.py 33.33% 1 Missing and 1 partial ⚠️
sdcflows/workflows/fit/pepolar.py 0.00% 1 Missing and 1 partial ⚠️
sdcflows/workflows/fit/syn.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   83.85%   83.68%   -0.18%     
==========================================
  Files          30       30              
  Lines        2819     2825       +6     
  Branches      365      368       +3     
==========================================
  Hits         2364     2364              
- Misses        384      387       +3     
- Partials       71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

effigies added a commit to effigies/fmriprep that referenced this pull request Jan 29, 2025
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable :)

@effigies
Copy link
Member Author

I've got a broken nipreps/fmriprep#3423 that is paired with this. I figure I should get that working before merging this. Was aiming for 25.0, but it was delayed enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants