[FIX] AttributeError for _ApplyCoeffsFieldInputSpec #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nipype expects the `xor` attribute for traits to always be a list. If it's just a string, then the individual characters of the string will be iterated, leading to an AttributeError when no single character attribute exists on the spec.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 83.85% 83.87% +0.01%
==========================================
Files 30 30
Lines 2819 2822 +3
Branches 365 366 +1
==========================================
+ Hits 2364 2367 +3
Misses 384 384
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgxd
previously approved these changes
Mar 7, 2025
effigies
force-pushed
the
fix/nipype-xor-list
branch
from
5cabd76 to
9c1c0c0
Compare
effigies
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Added a doctest. If I revert the @HippocampusGirl's fix, I get:
----------------------------------------------------- Captured log call ------------------------------------------------------
ERROR traits:trait_notifiers.py:220 Exception occurred in traits notification handler for object:
approx = True
data2fmap_xfm = ['/var/home/chris/Projects/nipreps/sdcflows/sdcflows/tests/data/epi2fmap_xfm.txt']
fmap2data_xfm = <undefined>
in_coeff = ['/var/home/chris/Projects/nipreps/sdcflows/sdcflows/tests/data/topup-coeff.nii.gz']
in_data = /var/home/chris/Projects/nipreps/sdcflows/sdcflows/tests/data/epi.nii.gz
in_xfms = <undefined>
jacobian = False
num_threads = <undefined>
pe_dir = ['j']
ro_time = [0.03125]
, trait: data2fmap_xfm, old value: <undefined>, new value: ['/var/home/chris/Projects/nipreps/sdcflows/sdcflows/tests/data/epi2fmap_xfm.txt']
Traceback (most recent call last):
File "/var/home/chris/Projects/nipreps/sdcflows/.tox/py312-latest/lib/python3.12/site-packages/traits/trait_notifiers.py", line 525, in _dispatch_change_event
self.dispatch(handler, *args)
File "/var/home/chris/Projects/nipreps/sdcflows/.tox/py312-latest/lib/python3.12/site-packages/traits/trait_notifiers.py", line 487, in dispatch
handler(*args)
File "/var/home/chris/Projects/nipreps/sdcflows/.tox/py312-latest/lib/python3.12/site-packages/nipype/interfaces/base/specs.py", line 110, in _xor_warn
if isdefined(getattr(self, trait_name)):
^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: '_ApplyCoeffsFieldInputSpec' object has no attribute 'f'
With the fix, the tests pass.
effigies
added a commit
that referenced
this pull request
Mar 21, 2025
2.12.0 (March 21, 2025) Feature release in the 2.12.x series. This release migrates from the deprecated ``niworkflows.reporting`` module to the ``nireports`` package. * FIX: AttributeError for _ApplyCoeffsFieldInputSpec (#481) * ENH: Allow running SyN SDC without using prior (#480) * ENH: Allow estimated and fallback TotalReadoutTime (#477) * RF: Transition from niworkflows reporting interfaces (#473) * DOC: Fix broken link [skip ci] (#482) * MNT: Add `defaults` to `conda` channels in `build-test-publish` GHA (#474) * MNT: Update `niworkflows` version to 1.11.0 (#478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been recently working with unstable fMRIPrep and have been getting the following error with SDCFlows 2.11.0 and Nipype 1.9.2:
As far as I can tell, Nipype expects the
xorattribute for traits to always be a list. It's just a string here thoughsdcflows/sdcflows/interfaces/bspline.py
Lines 302 to 311 in 50ace2a
If it's just a string, then the individual characters of the string will be iterated, leading to an AttributeError when no single character attribute exists on the spec.
I believe this may be related to #386
My conda environment