feat: improve get one byte performance #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use getByte() instead of get()
Member
Author
before
after
|
Member
Author
|
|
fengmk2
added a commit
to node-modules/hessian.js
that referenced
this pull request
Aug 7, 2017
improve read performance node-modules/byte#29
fengmk2
added a commit
to node-modules/hessian.js
that referenced
this pull request
Aug 7, 2017
- improve read performance node-modules/byte#29 - use fastbench instead of benchmark
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage ? 96.24%
=========================================
Files ? 2
Lines ? 346
Branches ? 79
=========================================
Hits ? 333
Misses ? 13
Partials ? 0
Continue to review full report at Codecov.
|
Member
Author
|
呃，为何没有继续推进。。 @gxcsoccer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use getByte() instead of get()