Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): add missing styles.styl file for de #988

Merged
merged 1 commit into from
Oct 20, 2016
Merged

fix(locale): add missing styles.styl file for de #988

merged 1 commit into from
Oct 20, 2016

Conversation

junedev
Copy link
Contributor

@junedev junedev commented Oct 20, 2016

Currently the styling of https://nodejs.org/de/ is broken. I think the reason is that I did not copy the styles.styl into the translation folder "locale/de" when working on #971. Unfortunately the bug did not appear when testing everything locally. Fixing the issue in this PR. Sorry for the inconvenience.

@zlatanvasovic
Copy link
Contributor

Related to #985. If we used only one stylesheet for all locales, there'd be no such issues.

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca merged commit 73c08b7 into nodejs:master Oct 20, 2016
@lpinca
Copy link
Member

lpinca commented Oct 20, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants