fix(gradle): strip single quotes from project names in composite build dependency report - #36859
Open
romain-petit-whoz wants to merge 2 commits into
Open
fix(gradle): strip single quotes from project names in composite build dependency report#36859romain-petit-whoz wants to merge 2 commits into
romain-petit-whoz wants to merge 2 commits into
Conversation
…d dependency report
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
vincent-couturier-whoz
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using
@nx/gradle/plugin-v1with Gradle composite builds (includeBuild),createDependenciesalways returns an empty array. No inter-project static dependenciesappear in
graph.dependencies— every Gradle project only has its implicitconfdependency.As a result,
filterAffectedcannot propagate changes through the Gradle dependency graph.Modifying a file in a leaf project (e.g.
commons) never marks dependent projects(e.g.
app,service) as affected.Root cause:
processGradleDependenciesparses lines of the form:and stores
"':app'"(with surrounding single quotes) ingradleProjectToDepsMap.But
gradleProjectNameToProjectRootMapis keyed without quotes:":app".The lookup silently returns
undefined— no error, no warning — and the dependency is dropped.Note: the existing composite build test mock used
-> project :my-utils:number-utils(no quotes), which is why this case was not caught by existing tests.
Expected Behavior
Inter-project Gradle dependencies from composite builds appear as
staticedges ingraph.dependencies, allowingfilterAffectedto correctly propagate changes throughthe Gradle dependency graph.
Related Issue(s)
Fixes #36858