Skip to content

fix(gradle): strip single quotes from project names in composite build dependency report #36859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romain-petit-whoz wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −1
Open

fix(gradle): strip single quotes from project names in composite build dependency report #36859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c12cb
fix(gradle): strip single quotes from project names in composite buil…
romain-petit-whoz Aug 31, 2026
902798e
Merge branch 'master' into master
romain-petit-whoz Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/gradle/src/plugin-v1/utils/__mocks__/gradle-composite-dependencies-quoted.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
compileClasspath - Compile classpath for source set 'main'.
+--- io.test.project:app -> project ':app'
\--- io.test.project:commons -> project ':commons'

implementationDependenciesMetadata
+--- io.test.project:app -> project ':app'
\--- io.test.project:commons -> project ':commons'
9 changes: 9 additions & 0 deletions packages/gradle/src/plugin-v1/utils/get-gradle-report.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,15 @@ describe('processGradleDependencies', () => {
]);
});

it('should strip single quotes from project names in composite builds', () => {
const depFilePath = join(
__dirname,
'utils/__mocks__/gradle-composite-dependencies-quoted.txt'
);
const dependencies = processGradleDependencies(depFilePath);
expect(Array.from(dependencies)).toEqual([':hemera-api', ':commons-web']);
});

it('should process gradle dependencies with regular build', () => {
const depFilePath = join(
__dirname,
Expand Down
2 changes: 1 addition & 1 deletion packages/gradle/src/plugin-v1/utils/get-gradle-report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ export function processGradleDependencies(depsFile: string): Set<string> {
.split(' ')?.[0];
} else if (dep.includes('-> project')) {
const [_, projectName] = dep.split('-> project');
targetProjectName = projectName.trim().split(' ')?.[0];
targetProjectName = projectName.trim().split(' ')?.[0].replace(/^'|'$/g, '');
}
if (targetProjectName) {
dependedProjects.add(targetProjectName);
Expand Down