Fix buffer pool #3353
Merged
Fix buffer pool #3353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3353 +/- ##
==========================================
+ Coverage 21.13% 21.18% +0.04%
==========================================
Files 718 718
Lines 53128 53128
==========================================
+ Hits 11230 11255 +25
+ Misses 41102 41081 -21
+ Partials 796 792 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NewBuffer() implies some pooled buffers and DefaultBufferPool is exactly that -- the default pool where buffers are put after use. This means that any given slice of data will end up there and then could be reused for any other gRPC-related purpose. This is not something users of replication API can expect, so surprising memory corruptions are quite possible. Regression of 3b853d5. Signed-off-by: Roman Khimov <[email protected]>
The same buffer pool problem. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
fix-buffer-pool
branch
from
5f0ae17 to
866590e
Compare
cthulhu-rider
approved these changes
May 16, 2025
carpawell
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.