Skip to content

Fix buffer pool #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Fix buffer pool #3353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cb0c71
node: fix incorrect gRPC buffer pool use, fix #3287
roman-khimov May 16, 2025
866590e
go.mod: upgrade SDK to a fixed version
roman-khimov May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ Changelog for NeoFS Node

### Fixed
- Basic income collection/distribution in networks with rate set to zero (#3352)
- Data corruption on replication in some cases (#3353)

### Changed

### Removed

### Updated
- `github.com/nspcc-dev/neofs-sdk-go` dependency to `v1.0.0-rc.13.0.20250516062127-1f3abc2c67ca` (#3353)

### Updating from v0.46.0

Expand Down
2 changes: 1 addition & 1 deletion cmd/neofs-node/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
func (protoCodecBinaryRequestOnly) Marshal(msg any) (mem.BufferSlice, error) {
bMsg, ok := msg.([]byte)
if ok {
return mem.BufferSlice{mem.NewBuffer(&bMsg, mem.DefaultBufferPool())}, nil
return mem.BufferSlice{mem.SliceBuffer(bMsg)}, nil

Check warning on line 55 in cmd/neofs-node/transport.go

View check run for this annotation

Codecov / codecov/patch

cmd/neofs-node/transport.go#L55 

Added line #L55 was not covered by tests
}

return nil, fmt.Errorf("message is not of type %T", bMsg)
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ require (
github.com/nspcc-dev/neo-go v0.109.1
github.com/nspcc-dev/neofs-api-go/v2 v2.14.1-0.20240827150555-5ce597aa14ea
github.com/nspcc-dev/neofs-contract v0.22.0
github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.13.0.20250514113748-9abf8c619246
github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.13.0.20250516062127-1f3abc2c67ca
github.com/nspcc-dev/tzhash v1.8.2
github.com/olekukonko/tablewriter v0.0.5
github.com/panjf2000/ants/v2 v2.9.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ github.com/nspcc-dev/neofs-api-go/v2 v2.14.1-0.20240827150555-5ce597aa14ea h1:mK
github.com/nspcc-dev/neofs-api-go/v2 v2.14.1-0.20240827150555-5ce597aa14ea/go.mod h1:YzhD4EZmC9Z/PNyd7ysC7WXgIgURc9uCG1UWDeV027Y=
github.com/nspcc-dev/neofs-contract v0.22.0 h1:dxSm/NYyc7ZtWlhskH4e4yzXxf5pBCEOR3lLLmV98i8=
github.com/nspcc-dev/neofs-contract v0.22.0/go.mod h1:it6Su92UvEFQDsMOfDIXapLu0j5TQSOvkS2YdUlPdgo=
github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.13.0.20250514113748-9abf8c619246 h1:Kk+ovE3645VF6ydZk0vqsEVKxYr/1EwIwg7mY0vsrTM=
github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.13.0.20250514113748-9abf8c619246/go.mod h1:j/NUu5iOGFkOVYM42XoC1X9DZD0/y89Pws++w5vxtQk=
github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.13.0.20250516062127-1f3abc2c67ca h1:RNdFnPHOe1Pz5yyJka6hVefYP1HqBRiTLmRI1g/f0wE=
github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.13.0.20250516062127-1f3abc2c67ca/go.mod h1:j/NUu5iOGFkOVYM42XoC1X9DZD0/y89Pws++w5vxtQk=
github.com/nspcc-dev/rfc6979 v0.2.3 h1:QNVykGZ3XjFwM/88rGfV3oj4rKNBy+nYI6jM7q19hDI=
github.com/nspcc-dev/rfc6979 v0.2.3/go.mod h1:q3sCL1Ed7homjqYK8KmFSzEmm+7Ngyo7PePbZanhaDE=
github.com/nspcc-dev/tzhash v1.8.2 h1:ebRCbPoEuoqrhC6sSZmrT/jI3h1SzCWakxxV6gp5QAg=
Expand Down
Loading