Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output to file option #44

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Add output to file option #44

merged 10 commits into from
Mar 7, 2024

Conversation

g-getsov
Copy link
Contributor

@g-getsov g-getsov commented Mar 3, 2024

Adding the option to output to file is a good way to circumvent Github's 1MB output limit and will also help with Github's issues around expanding variables containing unescaped special characters (often found in pattern regex fields in openapi specs).

@g-getsov
Copy link
Contributor Author

g-getsov commented Mar 3, 2024

Finishing a few things off on this, will ping when its ready for a review.

@g-getsov g-getsov changed the title [WIP] Add output to file option Add output to file option Mar 3, 2024
@g-getsov
Copy link
Contributor Author

g-getsov commented Mar 3, 2024

This is ready for a review now @effoeffi 🙏

@effoeffi effoeffi self-requested a review March 7, 2024 14:14
@effoeffi effoeffi self-assigned this Mar 7, 2024
@effoeffi effoeffi added the enhancement New feature or request label Mar 7, 2024
Copy link
Contributor

@effoeffi effoeffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing.
I have a comment, please, take a look at the breaking. The response is currently a summary, but I believe it would be better if the file contained all response data. What do you think?
In the future, we will also apply this to the diff and changelog.

@g-getsov
Copy link
Contributor Author

g-getsov commented Mar 7, 2024

@effoeffi Sounds good, done 👍

@effoeffi effoeffi merged commit b9a6a7c into oasdiff:main Mar 7, 2024
8 checks passed
@g-getsov g-getsov deleted the add-output-to-file-option branch March 7, 2024 17:42
@matheuswanted
Copy link

hey @g-getsov @effoeffi, I started having the following issue with the action after this PR:

/entrypoint.sh: source: line 4: can't open '/github/workspace/common/common.sh': No such file or directory

@effoeffi
Copy link
Contributor

effoeffi commented Mar 7, 2024

Thank you! I believe we should add it to the Dockerfile. I'm working on fixing it...

@effoeffi
Copy link
Contributor

effoeffi commented Mar 7, 2024

@g-getsov, it seems there is an issue with taking files that are not part of the action directory, so I have added it to each entrypoint.sh.
Can you please take a look at #45?

@effoeffi
Copy link
Contributor

effoeffi commented Mar 7, 2024

Fixed.
@matheuswanted can you please check?

@matheuswanted
Copy link

working now! thanks @effoeffi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants