-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output to file option #44
Conversation
Finishing a few things off on this, will ping when its ready for a review. |
This is ready for a review now @effoeffi 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for contributing.
I have a comment, please, take a look at the breaking. The response is currently a summary, but I believe it would be better if the file contained all response data. What do you think?
In the future, we will also apply this to the diff and changelog.
@effoeffi Sounds good, done 👍 |
Thank you! I believe we should add it to the Dockerfile. I'm working on fixing it... |
Fixed. |
working now! thanks @effoeffi |
Adding the option to output to file is a good way to circumvent Github's 1MB output limit and will also help with Github's issues around expanding variables containing unescaped special characters (often found in
pattern
regex fields in openapi specs).