make Ast_mapper iterate over all locations inside Longident.t #2737
+71
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
approved these changes
Oct 27, 2025
|
This looks like it might fix bugs we haven't encountered yet. Can you write an entry in CHANGES.md in case we want to mention them later ? |
These locations, which are new in 5.4, are sometimes traversed (e.g. Pexp_setfield) and
sometimes not (e.g. Pexp_field). So clearly a bug.
The fix is concretely:
- change map_loc to map over both fields `{ loc; txt }` of `Location.loc`
- propagate the change, ie change `map_loc` to `map_string_loc`,
`map_string_opt_loc` or `map_loc_lid` depending on the type. All occurrences
of the latter are bug fixes.
v-gb
force-pushed
the
push-wtoxqxoouqsm
branch
from
f1a23a4 to
f8b6a44
Compare
What do you mean, concretely ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These locations, which are new in 5.4, are sometimes traversed (e.g. Pexp_setfield) and sometimes not (e.g. Pexp_field). So clearly a bug.
The fix is concretely:
{ loc; txt }ofLocation.locmap_loctomap_string_loc,map_string_opt_locormap_loc_liddepending on the type. All occurrences of the latter are bug fixes.