Skip to content

[FIX] functions: wrong error message for SORT #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] functions: wrong error message for SORT #7164

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Sep 17, 2025

Description

There was a bunch of problems in the errors messages of the SORT and SORTN functions:

  • we were using %d, which isn't supported
  • the index displayed is always wrong
  • we display the same index for both SORT and SORTN while they have different number of mandatory arguments
  • the message said we expected a number or a range while is_ascending

Task: 5085267

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7163
Forward-Port-Of: #7135

@hokolomopo
[FIX] functions: wrong error message for SORT
0852f7e 
There was a bunch of problems in the errors messages of the `SORT`
and `SORTN` functions:

- we were using %d, which isn't supported
- the index displayed is always wrong
- we display the same index for both `SORT` and `SORTN` while they
    have different number of mandatory arguments
- the message said we expected `a number or a range` while `is_ascending`
    is a boolean

Task: 5085267
X-original-commit: 716824c
@robodoo
Copy link
Collaborator

robodoo commented Sep 17, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Sep 17, 2025

This PR targets 19.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Sep 17, 2025
Closed
14 tasks
@robodoo robodoo closed this in ea0afdf Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fw-bot @robodoo @hokolomopo