Repository navigation
fix(vtex): stop echoing a page the key already resolved - #13
Merged
Merged
Conversation
`pageOf` put the resolved page in the key, and the loop below went on appending the raw `?page` on top of it. The two no longer agree — resolved 0 against a raw 1 — so the dedup that used to collapse them cannot, and one page becomes two entries: the storefront renders page 1 with no `?page` at all while its own client-side pagination asks for that same page as `?page=1`. Measured: the render warms it (miss 1738ms) and the client-side call now reads it (hit 8ms); page 2 still mints its own (miss 1997ms) and both keep hitting. Before, each side had its own entry for identical products. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YFJdpNZtWBobnhj3CPPuMj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11, found while validating the storefront's new client-side PLP against it.
pageOfresolves the page into the cache key. The loop that echoes allowed URL params then appended the raw?pageon top, and the two no longer agree — a resolved0against a raw1— so the dedup that used to collapse them cannot. One page becomes two entries: the storefront renders page 1 with no?pageat all, while its own client-side pagination asks for that same page as?page=1.pageleaves the echo list; nothing else reads it from there.Measured
?page(warms)?page=1?page=2?page