Skip to content

fix(vtex): stop echoing a page the key already resolved #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoferreiradev merged 1 commit into from
Sep 2, 2026
Merged

fix(vtex): stop echoing a page the key already resolved #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion vtex/loaders/intelligentSearch/productListingPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,17 @@ export const mapLabelledFuzzyToFuzzy = (
return;
}
};
/**
* URL params that still say something the props block above did not already say.
*
* `page` is deliberately absent: `pageOf` already resolved it into the key, and
* echoing the raw value on top splits one page in two — the storefront renders
* page 1 with no `?page` while its own client-side pagination asks for the same
* page as `?page=1`.
*/
const ALLOWED_PARAMS = new Set([
"ps",
"sort",
"page",
"o",
"q",
"fuzzy",
Expand Down