Make Item Set Browse Results Match Paginator#2310
Draft
alexdryden wants to merge 2 commits intoomeka:developfrom
Draft
Make Item Set Browse Results Match Paginator#2310alexdryden wants to merge 2 commits intoomeka:developfrom
alexdryden wants to merge 2 commits intoomeka:developfrom
Conversation
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr proposes two different ways to address #2035 by setting the query parameter for page on the site item set browse page.
The first method calls
browse()->setDefaults()to se the default query parameters, as is done in the admin browse. The downside to this is that it will set all defaults and change the sort order for existing installations.The second method sets the
pagequery parameter to 1 if it is not set already.