Skip to content

Make Item Set Browse Results Match Paginator #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexdryden wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Make Item Set Browse Results Match Paginator #2310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27fbb7a
fix: set page query parameter
alexdryden Jun 17, 2025
0c34713
fix: run linter
alexdryden Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions application/src/Controller/Site/ItemSetController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ public function browseAction()

$query = $this->params()->fromQuery();
$query['site_id'] = $site->id();

//this is the same approach as admin, but it will change the sort order and other defaults
//$this->browse()->setDefaults('item_sets');

//this will only set the page
$query['page'] ??= 1;

$response = $this->api()->search('item_sets', $query);
$this->paginator($response->getTotalResults());
$itemSets = $response->getContent();
Expand Down