Skip to content

[L0] Update UR to link the Loader as static #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[L0] Update UR to link the Loader as static #2667

wants to merge 1 commit into from

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Feb 5, 2025

No description provided.

@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch 2 times, most recently from d15d98d to 96d65cb Compare February 5, 2025 23:25
@github-actions github-actions bot added the level-zero L0 adapter specific issues label Feb 5, 2025
@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch 3 times, most recently from 58ff0fd to b107caa Compare February 7, 2025 17:00
pbalcer
pbalcer reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch 4 times, most recently from 59896f1 to 06dc361 Compare February 11, 2025 21:35
@github-actions github-actions bot added the ci/cd Continuous integration/devliery label Feb 11, 2025
@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch from b00a1e9 to 7df2131 Compare February 13, 2025 16:09
@igchor igchor mentioned this pull request Feb 14, 2025
Closed
@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch 3 times, most recently from e249e0e to 719f8e9 Compare February 14, 2025 23:36
@github-actions github-actions bot added the common Changes or additions to common utilities label Feb 14, 2025
@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch 2 times, most recently from 0713e88 to 0c4a9fa Compare February 19, 2025 23:00
@martygrant
Copy link
Contributor

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

This is an automated comment.

@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch 2 times, most recently from 298eee4 to 4e11111 Compare February 20, 2025 19:34
@nrspruit
[L0] Update UR to link the Loader as static
c32e2a8 
- [L0] Update to build L0 Adapter with static loader in all times
- Fix urKernelCreateWithNativeHandle to properly init L0 before use
- Fix v2 tests that directly link Loader which statically link

Signed-off-by: Neil R. Spruit <[email protected]>
@nrspruit nrspruit force-pushed the UR_L0_STATIC_LOADER branch from 4e11111 to c32e2a8 Compare February 20, 2025 19:49
@nrspruit nrspruit mentioned this pull request Feb 20, 2025
Merged
@nrspruit nrspruit closed this Feb 20, 2025
sarnex pushed a commit to intel/llvm that referenced this pull request Mar 3, 2025
@nrspruit
[UR] [L0] Update UR to link the Loader as static (#17104)
f01edd3 
Migrated from oneapi-src/unified-runtime#2667

---------

Signed-off-by: Neil R. Spruit <[email protected]>
kbenzie pushed a commit to kbenzie/unified-runtime that referenced this pull request Mar 4, 2025
@nrspruit @kbenzie
Update UR to link the Loader as static (#17104)
ae86b93 
Migrated from oneapi-src#2667

---------

Signed-off-by: Neil R. Spruit <[email protected]>
RossBrunton pushed a commit that referenced this pull request Mar 6, 2025
@nrspruit @RossBrunton
Update UR to link the Loader as static (#17104)
decac3b 
Migrated from #2667

---------

Signed-off-by: Neil R. Spruit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer left review comments

Assignees
No one assigned
Labels
ci/cd Continuous integration/devliery common Changes or additions to common utilities level-zero L0 adapter specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrspruit @martygrant @pbalcer