Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to EIP-1193 / EIP-1474 Error Format #2117

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 5, 2025

Closes #2114

Currently, we will report everything as an internal error. Errors already formatted correctly will be treated as passthrough. We can add a better level of granularity later on.

@jribbink jribbink changed the base branch from master to feature/cross-vm February 5, 2025 09:25
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: b735d7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the title Jribbink/error format Adhere to EIP-1193 Error Format Feb 6, 2025
@jribbink jribbink force-pushed the jribbink/error-format branch from 7f10266 to dbbb6da Compare February 6, 2025 08:52
@jribbink jribbink changed the title Adhere to EIP-1193 Error Format Adhere to EIP-1193 / EIP-1474 Error Format Feb 6, 2025
@jribbink jribbink marked this pull request as ready for review February 6, 2025 08:53
@jribbink jribbink requested a review from a team as a code owner February 6, 2025 08:53
@jribbink jribbink merged commit d8d7523 into feature/cross-vm Feb 6, 2025
1 check passed
@jribbink jribbink deleted the jribbink/error-format branch February 6, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants