-
Notifications
You must be signed in to change notification settings - Fork 201
Bump onflow/go-ethereum dependency to v1.15.9
#7241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump onflow/go-ethereum dependency to v1.15.9
#7241
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pectra-upgrade #7241 +/- ##
==========================================================
- Coverage 41.31% 41.31% -0.01%
==========================================================
Files 2164 2164
Lines 189596 189641 +45
==========================================================
+ Hits 78335 78344 +9
- Misses 104734 104765 +31
- Partials 6527 6532 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
02c346f to
d5fdbe3
Compare
onflow/go-ethereum dependency to v1.15.7onflow/go-ethereum dependency to v1.15.8
| func (db *StateDB) SetNonce( | ||
| addr gethCommon.Address, | ||
| nonce uint64, | ||
| reason gethTracing.NonceChangeReason, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, the Geth folks introduced this gethTracing.NonceChangeReason function parameter, but it's not used anywhere within the method's body.
See: https://github.com/ethereum/go-ethereum/blob/v1.15.8/core/state/statedb.go#L435-L440
| return updateCommit, nil | ||
| } | ||
|
|
||
| func (db *StateDB) Finalise(deleteEmptyObjects bool) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a no-op in our case, because our custom implementation of StateDB, already handles the finalization and deletion of empty objects as part of Commit .
| castedValue, | ||
| call.GasLimit) | ||
| call.GasLimit, | ||
| nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the deployment of COAs, we pass nil for the jumpDests argument, as it is not exposed through the EVM object. See also:
onflow/go-ethereum dependency to v1.15.8onflow/go-ethereum dependency to v1.15.9
No description provided.