Skip to content

Conversation

@m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Apr 4, 2025

No description provided.

@m-Peter m-Peter self-assigned this Apr 4, 2025
@m-Peter m-Peter requested review from a team, janezpodhostnik and zhangchiqing as code owners April 4, 2025 12:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 64.36782% with 31 lines in your changes missing coverage. Please review.

Project coverage is 41.31%. Comparing base (68a94e8) to head (ebd7db9).

Files with missing lines Patch % Lines
fvm/evm/emulator/state/stateDB.go 58.33% 15 Missing ⚠️
fvm/evm/types/call.go 0.00% 8 Missing ⚠️
fvm/evm/emulator/emulator.go 82.85% 5 Missing and 1 partial ⚠️
fvm/evm/emulator/state/delta.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/pectra-upgrade    #7241      +/-   ##
==========================================================
- Coverage                   41.31%   41.31%   -0.01%     
==========================================================
  Files                        2164     2164              
  Lines                      189596   189641      +45     
==========================================================
+ Hits                        78335    78344       +9     
- Misses                     104734   104765      +31     
- Partials                     6527     6532       +5     
Flag Coverage Δ
unittests 41.31% <64.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-Peter m-Peter changed the base branch from feature/pectra-upgrade to mpeter/update-go-ethereum-v1.15.6 April 4, 2025 13:16
@m-Peter m-Peter changed the base branch from mpeter/update-go-ethereum-v1.15.6 to feature/pectra-upgrade April 9, 2025 06:18
@m-Peter m-Peter force-pushed the mpeter/update-go-ethereum-v1.15.7 branch from 02c346f to d5fdbe3 Compare April 10, 2025 11:28
@m-Peter m-Peter changed the title Bump onflow/go-ethereum dependency to v1.15.7 Bump onflow/go-ethereum dependency to v1.15.8 Apr 17, 2025
func (db *StateDB) SetNonce(
addr gethCommon.Address,
nonce uint64,
reason gethTracing.NonceChangeReason,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the Geth folks introduced this gethTracing.NonceChangeReason function parameter, but it's not used anywhere within the method's body.
See: https://github.com/ethereum/go-ethereum/blob/v1.15.8/core/state/statedb.go#L435-L440

return updateCommit, nil
}

func (db *StateDB) Finalise(deleteEmptyObjects bool) {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no-op in our case, because our custom implementation of StateDB, already handles the finalization and deletion of empty objects as part of Commit .

castedValue,
call.GasLimit)
call.GasLimit,
nil,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the deployment of COAs, we pass nil for the jumpDests argument, as it is not exposed through the EVM object. See also:

@m-Peter m-Peter changed the title Bump onflow/go-ethereum dependency to v1.15.8 Bump onflow/go-ethereum dependency to v1.15.9 Apr 22, 2025
@m-Peter m-Peter merged commit 9c60e1f into feature/pectra-upgrade Apr 22, 2025
56 checks passed
@m-Peter m-Peter deleted the mpeter/update-go-ethereum-v1.15.7 branch April 22, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants