Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new metrics for vcenter receiver VM performance related met… #37489

Merged
merged 1 commit into from
Feb 5, 2025
Merged

added new metrics for vcenter receiver VM performance related met… #37489

merged 1 commit into from
Feb 5, 2025

Conversation

samiura
Copy link
Contributor

@samiura samiura commented Jan 25, 2025 •
edited
Loading

Description

This PR adds the following VM performance metrics for vcenter.

  1. vcenter.vm.cpu.time
  2. vcenter.vm.network.multicast.packet.rate
  3. vcenter.vm.network.broadcast.packet.rate

More information on these metrics can be found here. and also succinctly described here

#37488

Testing

The metrics were scraped from a test vCenter environment, and golden test files were updated accordingly to reflect the addition of the metric.

Documentation

Documentation was updated according to the metadata.yaml
evidence1
Screenshot 2025-01-29 at 10 48 33 AM
Screenshot 2025-01-29 at 10 53 54 AM
Screenshot 2025-01-29 at 10 54 11 AM

@samiura samiura mentioned this pull request Jan 25, 2025
Open
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 2 times, most recently from 816b219 to 8994147 Compare January 25, 2025 01:22
@samiura samiura marked this pull request as ready for review January 25, 2025 01:38
@samiura samiura requested a review from a team as a code owner January 25, 2025 01:38
@samiura samiura requested a review from fatsheep9146 January 25, 2025 01:38
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch from 8994147 to 9ddb446 Compare January 27, 2025 17:29
StefanKurek
StefanKurek suggested changes Jan 27, 2025
View reviewed changes
receiver/vcenterreceiver/metrics.go Outdated Show resolved Hide resolved
receiver/vcenterreceiver/metrics.go Outdated Show resolved Hide resolved
receiver/vcenterreceiver/metrics.go Outdated Show resolved Hide resolved
receiver/vcenterreceiver/metrics.go Outdated Show resolved Hide resolved
receiver/vcenterreceiver/scraper_test.go Outdated Show resolved Hide resolved
receiver/vcenterreceiver/metrics.go Outdated Show resolved Hide resolved
receiver/vcenterreceiver/testdata/metrics/expected-all-enabled.yaml Show resolved Hide resolved
receiver/vcenterreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/vcenterreceiver/metadata.yaml Outdated Show resolved Hide resolved
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 4 times, most recently from 35288a1 to 71df9a7 Compare January 28, 2025 00:28
@samiura samiura requested a review from StefanKurek January 28, 2025 00:30
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch from 71df9a7 to 5864227 Compare January 28, 2025 16:54
StefanKurek
StefanKurek reviewed Jan 28, 2025
View reviewed changes
receiver/vcenterreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/vcenterreceiver/metadata.yaml Outdated Show resolved Hide resolved
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 3 times, most recently from 8945f4f to 83c94de Compare January 28, 2025 17:30
StefanKurek
StefanKurek reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@StefanKurek StefanKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it mostly looks pretty good now, but I still have a couple of questions for possible improvements.

receiver/vcenterreceiver/metadata.yaml Outdated Show resolved Hide resolved
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 5 times, most recently from cc899eb to 3fe930c Compare January 28, 2025 20:21
@samiura samiura requested a review from StefanKurek January 28, 2025 20:22
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch from 3fe930c to 6c76884 Compare January 28, 2025 20:33
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 3 times, most recently from 5279abd to 636c6c7 Compare February 4, 2025 17:40
@crobert-1
Copy link
Member

Removing ready to merge as the PR must be approved by an approver or maintainer before being merged.

@crobert-1 crobert-1 removed the ready to merge Code review completed; ready to merge by maintainers label Feb 4, 2025
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 5 times, most recently from e8a7d1e to f6e865c Compare February 4, 2025 20:58
@samiura
Copy link
Contributor Author

samiura commented Feb 4, 2025

Removing ready to merge as the PR must be approved by an approver or maintainer before being merged.

Since, you (@crobert-1 ) are an approver, can we have your review. As you see, one of the codeowner has spent a quite long time on reviewing this before finally approving.

@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 3 times, most recently from a21d98a to 3ae1301 Compare February 4, 2025 22:45
@crobert-1 crobert-1 added ready to merge Code review completed; ready to merge by maintainers enhancement New feature or request labels Feb 5, 2025
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch 5 times, most recently from 39623fd to bcfe153 Compare February 5, 2025 18:20
@samiura
Signed-off-by: Samiur Arif <[email protected]>
7320fc2 
addressed previous PR comments.

Signed-off-by: Samiur Arif <[email protected]>
@samiura samiura force-pushed the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch from bcfe153 to 7320fc2 Compare February 5, 2025 18:20
@songy23 songy23 merged commit f342012 into open-telemetry:main Feb 5, 2025
163 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 5, 2025
@samiura samiura deleted the add-more-vecenter-receiver-virtual-machine-preformace-metrics branch February 5, 2025 19:09
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Feb 8, 2025
@samiura @chengchuanpeng
added new metrics for vcenter receiver VM performance related met… (o…
1274615 
…pen-telemetry#37489)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds the following VM performance metrics for vcenter.

1. `vcenter.vm.cpu.time`
2. `vcenter.vm.network.multicast.packet.rate`
3. `vcenter.vm.network.broadcast.packet.rate`

More information on these metrics can be found
[here](https://docs.vmware.com/en/vRealize-Operations/8.10/com.vmware.vcom.metrics.doc/GUID-41603CD6-453B-4E26-A237-34E733BAB00C.html).
and also succinctly described
[here](https://www.servicenow.com/docs/bundle/xanadu-it-operations-management/page/product/agent-client-collector/reference/vsphere-metrics.html)

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
open-telemetry#37488 


<!--Describe what testing was performed and which tests were added.-->
#### Testing
The metrics were scraped from a test vCenter environment, and golden
test files were updated accordingly to reflect the addition of the
metric.


<!--Describe the documentation added.-->
#### Documentation
Documentation was updated according to the metadata.yaml
<img width="1776" alt="evidence1"
src="https://github.com/user-attachments/assets/662d6ff5-dda5-4e56-b124-5b401992871a"
/>
<img width="650" alt="Screenshot 2025-01-29 at 10 48 33 AM"
src="https://github.com/user-attachments/assets/c421ed17-d718-4f78-b5d1-4b96627d7584"
/>
<img width="125" alt="Screenshot 2025-01-29 at 10 53 54 AM"
src="https://github.com/user-attachments/assets/12317bf0-d767-4d6d-ad2f-0daf07c18555"
/>
<img width="933" alt="Screenshot 2025-01-29 at 10 54 11 AM"
src="https://github.com/user-attachments/assets/331a31fb-0574-4465-8fc5-240be40e2684"
/>

Signed-off-by: Samiur Arif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanotti pjanotti pjanotti approved these changes

@StefanKurek StefanKurek StefanKurek approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@chan-tim-sumo chan-tim-sumo chan-tim-sumo approved these changes

@schmikei schmikei Awaiting requested review from schmikei

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@dashpole dashpole

Labels
enhancement New feature or request ready to merge Code review completed; ready to merge by maintainers receiver/vcenter
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
7 participants
@samiura @StefanKurek @pjanotti @crobert-1 @chan-tim-sumo @dashpole @songy23