template code with s3 fetch #1
Conversation
There was a problem hiding this comment.
@braddf the main focus for this pr should be this file
|
@braddf, apart from the file I said on, please feel free to skim through the rest since most of the files are auto-generated by fastapi-template. The testing framework is set up, but there aren’t any real tests yet; I plan to add them later this week for the S3 fetch. The same goes for the README.md. |
| @@ -1,19 +0,0 @@ | |||
| name: Non-Default Branch Push CI (Python) | |||
There was a problem hiding this comment.
Could you reinstate these two default workflows? So that this repo does the same things as others 👍
|
|
||
| class InterceptHandler(logging.Handler): | ||
| """ | ||
| Default handler from examples in loguru documentation. |
There was a problem hiding this comment.
Haven't used loguru before, but will give it a go!
| "cloudcasting_backend/static/layers" # Base directory for all GeoTIFF output | ||
| ) | ||
| # Bounding box for cropping the GeoTIFF output [lon_min, lat_min, lon_max, lat_max] | ||
| GEOTIFF_BBOX = [-19.0, 42.0, 15.0, 65.0] |
There was a problem hiding this comment.
Is this the same for both MET-10 and MET-11?
| dst.write(data, 1) | ||
| log.success(f"Successfully saved GeoTIFF to {filename}") | ||
| except Exception as e: | ||
| log.opt(exception=e).error(f"Failed to save GeoTIFF file: {filename}") |
There was a problem hiding this comment.
So actually, I know I said Sentry works out of the box, but if you're catching and logging exceptions like here, then you can also just fire them into Sentry using the functions in the lib, which collects them nicely for reviewing
suvanbanerjee
force-pushed
the
template
branch
from
3f4c8fc to
efd7cc8
Compare
No description provided.