Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add start and end times on forecast and generation #120

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 6, 2023

Pull Request

Description

add start and end filters for generations and forecasts

This one first #119

Fixes #110

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as draft September 6, 2023 11:18
@peterdudfield peterdudfield mentioned this pull request Sep 6, 2023
6 tasks
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #120 (5a016e8) into main (a55d835) will increase coverage by 2.85%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   92.42%   95.28%   +2.85%     
==========================================
  Files          11       11              
  Lines         568      636      +68     
==========================================
+ Hits          525      606      +81     
+ Misses         43       30      -13     
Files Changed Coverage Δ
pv_site_api/__init__.py 100.00% <100.00%> (ø)
pv_site_api/_db_helpers.py 99.21% <100.00%> (+14.11%) ⬆️
pv_site_api/convert.py 100.00% <100.00%> (ø)
pv_site_api/main.py 93.92% <100.00%> (+0.36%) ⬆️
pv_site_api/utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterdudfield peterdudfield requested a review from zakwatts July 19, 2024 11:51
@peterdudfield peterdudfield marked this pull request as ready for review July 19, 2024 11:51
@zakwatts
Copy link
Contributor

LGTM

@peterdudfield peterdudfield merged commit ed26213 into main Jul 19, 2024
2 checks passed
@peterdudfield peterdudfield deleted the start-end-times branch July 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add time filters on forecast and true routes
2 participants