Job/jobbase unification test fixtures - #177
Merged
Merged
Conversation
JobBase.userUuid (and JobSerialized.userUuid) was widened from string to string | undefined upstream in arena-core as a defensive null-safety change. Add an early return in JobManager.onMessage() so tsc can narrow userUuid to a definite string for the rest of the method, instead of failing to type-check the Map lookup, the WebSocketServer.notifyUser call, and the workers.delete() call inside the setTimeout closure. Fixes TS2345 errors reported against jobManager.ts:22,24,30. A job update message always carries a userUuid in practice (every job is created for a specific user), so this is a no-op guard rather than a change in expected behavior.
Points at the real published JobBase unification (was verified locally via yarn link during development; this replaces that local link with the actual published package now that the arena-core PR has merged). Re-verified against the published package: tsc clean, full test suite 16/16 suites, 67/67 tests passing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.