Add method reference to FuncOp#992
Conversation
|
👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
|
||
| this.funcName = funcName; | ||
| this.body = bodyBuilder.build(this); | ||
| this.mref = MethodRef.method(null, funcName, body.bodyType()); |
There was a problem hiding this comment.
I like that you reused the method reference, but I am unsure about using null as for the reference owner type, arguably MethodRef should throw NPE for any given null arguments. Perhaps we can use void?
|
@mabbay this pull request can not be integrated into git checkout funcop-mref
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push |
# Conflicts: # src/jdk.incubator.code/share/classes/jdk/incubator/code/dialect/core/CoreOp.java
|
/template append |
|
@mabbay The pull request template has been appended to the pull request body |
# Conflicts: # src/jdk.incubator.code/share/classes/jdk/incubator/code/dialect/core/CoreOp.java
This reverts commit c634d41.
Allow user to attach a MethodRef to a FuncOp.
Compiler tests are failing because of these changes, I will updated them gradually.
Attaching MethodRef to FuncOp will allow us to access the original j.l.r.Method from which we extracted a FuncOp -JDK-8376824
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/992/head:pull/992$ git checkout pull/992Update a local copy of the PR:
$ git checkout pull/992$ git pull https://git.openjdk.org/babylon.git pull/992/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 992View PR using the GUI difftool:
$ git pr show -t 992Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/992.diff