Skip to content

Add method reference to FuncOp#992

Draft
mabbay wants to merge 21 commits intoopenjdk:code-reflectionfrom
mabbay:funcop-mref
Draft

Add method reference to FuncOp#992
mabbay wants to merge 21 commits intoopenjdk:code-reflectionfrom
mabbay:funcop-mref

Conversation

@mabbay
Copy link
Copy Markdown
Member

@mabbay mabbay commented Apr 3, 2026

Allow user to attach a MethodRef to a FuncOp.
Compiler tests are failing because of these changes, I will updated them gradually.
Attaching MethodRef to FuncOp will allow us to access the original j.l.r.Method from which we extracted a FuncOp -JDK-8376824



Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/992/head:pull/992
$ git checkout pull/992

Update a local copy of the PR:
$ git checkout pull/992
$ git pull https://git.openjdk.org/babylon.git pull/992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 992

View PR using the GUI difftool:
$ git pr show -t 992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/992.diff

@mabbay mabbay requested review from PaulSandoz and mcimadamore April 3, 2026 19:08
@mabbay mabbay self-assigned this Apr 3, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 3, 2026

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 3, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.


this.funcName = funcName;
this.body = bodyBuilder.build(this);
this.mref = MethodRef.method(null, funcName, body.bodyType());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you reused the method reference, but I am unsure about using null as for the reference owner type, arguably MethodRef should throw NPE for any given null arguments. Perhaps we can use void?

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 10, 2026

@mabbay this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout funcop-mref
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push

@openjdk openjdk Bot added the merge-conflict Pull request has merge conflict with target branch label Apr 10, 2026
@openjdk openjdk Bot removed the merge-conflict Pull request has merge conflict with target branch label Apr 13, 2026
@mabbay
Copy link
Copy Markdown
Member Author

mabbay commented Apr 13, 2026

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 13, 2026

@mabbay The pull request template has been appended to the pull request body

@mabbay mabbay requested a review from grfrost April 28, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants