-
Notifications
You must be signed in to change notification settings - Fork 37
Add method reference to FuncOp #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mabbay
wants to merge
21
commits into
openjdk:code-reflection
Choose a base branch
from
mabbay:funcop-mref
base: code-reflection
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ab41cc6
Add method reference to FuncOp
mabbay 7f8bd2f
Add method FuncOp.mref
mabbay 8bf4ebf
Use JavaType.VOID as MethodRef 's refType when no MethodRef is provided
mabbay 7528802
Add overloads of func
mabbay dae685b
Use a special value to indicate FuncOp was created with no MethodRef
mabbay 1c6d161
Test FuncOp method ref
mabbay d125e02
Merge branch 'code-reflection' into funcop-mref
mabbay 6f2ee82
Test both variants of func factory methods
mabbay 6d9be75
Merge branch 'code-reflection' into funcop-mref
mabbay 71c5338
Delete func factory methods that accept MethodRef
mabbay ce4d1a1
Remove FuncOp.mref field
mabbay 39f1f99
Rename refType to ownerType
mabbay 5cf983f
Throw when attribute func.owner.type is present but not a CodeType
mabbay 746345b
Change FuncOp.NO_OWNER_TYPE type to CodeType
mabbay d5ba947
Update TestFuncOpMethodRef
mabbay 5adf789
Add MethodKind to FuncOp
mabbay 026293e
Update TestFuncOpMethodRef
mabbay c634d41
Update ArrayAccessTest
mabbay 71e871a
Revert "Update ArrayAccessTest"
mabbay 1c4b973
Document func methods
mabbay 46777bc
Remove commented tests
mabbay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @modules jdk.incubator.code | ||
| * @modules jdk.incubator.code/jdk.incubator.code.internal | ||
| * @library lib | ||
| * @run junit TestFuncOpMethodRef | ||
| */ | ||
|
|
||
| import jdk.incubator.code.Body; | ||
| import jdk.incubator.code.CodeTransformer; | ||
| import jdk.incubator.code.dialect.core.CoreOp; | ||
| import jdk.incubator.code.dialect.core.CoreType; | ||
| import jdk.incubator.code.dialect.core.FunctionType; | ||
| import jdk.incubator.code.dialect.java.FieldRef; | ||
| import jdk.incubator.code.dialect.java.JavaOp; | ||
| import jdk.incubator.code.dialect.java.JavaType; | ||
| import jdk.incubator.code.dialect.java.MethodRef; | ||
| import jdk.incubator.code.extern.DialectFactory; | ||
| import jdk.incubator.code.internal.OpBuilder; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.lang.invoke.MethodHandles; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static jdk.incubator.code.dialect.core.CoreOp.*; | ||
|
|
||
| public class TestFuncOpMethodRef { | ||
| private final JavaType thisType = JavaType.type(this.getClass().describeConstable().get()); | ||
| private final MethodRef MR = MethodRef.method(thisType, "f", CoreType.FUNCTION_TYPE_VOID); | ||
|
|
||
| @Test | ||
| void test() { | ||
| FuncOp f = func(MR.name(), CoreType.FUNCTION_TYPE_VOID).body(b -> { | ||
| b.op(return_()); | ||
| }); | ||
| Assertions.assertTrue(f.mref().isEmpty()); | ||
|
|
||
| CoreOp.FuncOp cf = externalizeAndCreate(f); | ||
| Assertions.assertTrue(cf.mref().isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| void test2() { | ||
| FuncOp f = func(MR.refType(), MR.name(), MR.signature(), FuncOp.MethodKind.STATIC).body(b -> { | ||
| b.op(return_()); | ||
| }); | ||
| Assertions.assertTrue(f.mref().isPresent()); | ||
| Assertions.assertEquals(MR, f.mref().get()); | ||
|
|
||
| CoreOp.FuncOp cf = externalizeAndCreate(f); | ||
| Assertions.assertTrue(cf.mref().isPresent()); | ||
|
|
||
| Assertions.assertEquals(f.mref().get(), cf.mref().get()); | ||
| } | ||
|
|
||
| @Test | ||
| void test5() { | ||
| Body.Builder bb = Body.Builder.of(null, CoreType.FUNCTION_TYPE_VOID); | ||
| bb.entryBlock().op(return_()); | ||
| FuncOp f = func(MR.refType(), MR.name(), bb, FuncOp.MethodKind.STATIC); | ||
| Assertions.assertTrue(f.mref().isPresent()); | ||
| Assertions.assertEquals(MR, f.mref().get()); | ||
|
|
||
| FuncOp cf = externalizeAndCreate(f); | ||
| Assertions.assertTrue(cf.mref().isPresent()); | ||
| Assertions.assertEquals(f.mref().get(), cf.mref().get()); | ||
| } | ||
|
|
||
| @Test | ||
| void test6() { | ||
| Body.Builder bb = Body.Builder.of(null, CoreType.FUNCTION_TYPE_VOID); | ||
| bb.entryBlock().op(return_()); | ||
| FuncOp f = func(MR.name(), bb); | ||
| Assertions.assertTrue(f.mref().isEmpty()); | ||
|
|
||
| FuncOp cf = externalizeAndCreate(f); | ||
| Assertions.assertTrue(cf.mref().isEmpty()); | ||
| } | ||
|
|
||
| private static FuncOp externalizeAndCreate(FuncOp f) { | ||
| ModuleOp mop = OpBuilder.createBuilderFunctions(new LinkedHashMap<>(Map.of(f.funcName(), f)), | ||
| b -> b.op(JavaOp.fieldLoad( | ||
| FieldRef.field(JavaOp.class, "JAVA_DIALECT_FACTORY", DialectFactory.class)))); | ||
| CoreOp.FuncOp cf = (CoreOp.FuncOp) Interpreter.invoke(MethodHandles.lookup(), | ||
| mop.transform(CodeTransformer.LOWERING_TRANSFORMER).functionTable().get(f.funcName())); | ||
| return cf; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.