8358769: Update --release 25 symbol information for JDK 25 build 26 #25854

nizarbenalla · 2025-06-17T15:20:44Z

Usual symbol file update for a new JDK build.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8358769: Update --release 25 symbol information for JDK 25 build 26 (Sub-task - P4)

Reviewers

Joe Darcy (@jddarcy - Reviewer)
Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25854/head:pull/25854
$ git checkout pull/25854

Update a local copy of the PR:
$ git checkout pull/25854
$ git pull https://git.openjdk.org/jdk.git pull/25854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25854

View PR using the GUI difftool:
$ git pr show -t 25854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25854.diff

Using Webrev

Link to Webrev Comment

The macOS/AArch64 build 27 was taken from https://jdk.java.net/25/

bridgekeeper · 2025-06-17T15:21:38Z

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-17T15:23:09Z

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358769: Update --release 25 symbol information for JDK 25 build 26

Reviewed-by: darcy, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

b7fcd0b: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar
984d7f9: 8359895: JFR: method-timing view doesn't work
42d3604: 8359923: Const accessors for the Deferred class
... and 32 more: https://git.openjdk.org/jdk/compare/9d060574e5dbd13e634f00d749d0108ceff1fae8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-06-17T15:23:49Z

@nizarbenalla The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-17T15:27:02Z

Webrevs

01: Full - Incremental (9ec49c40)
00: Full (e576baf6)

jddarcy · 2025-06-17T16:24:04Z

src/jdk.compiler/share/data/symbols/java.base-P.sym.txt

@@ -51,6 +51,10 @@ class name java/io/ProxyingConsole
 -method name readln descriptor (Ljava/lang/String;)Ljava/lang/String;
 -method name readln descriptor ()Ljava/lang/String;

+class name java/io/Reader


Seeing this is surprising since JDK-8354724: "Methods in java.io.Reader to read all characters and all lines" which added these methods was add in JDK 25 build 26 while, presumably many other changes from build 26 are already present in the symbol file.

I used "build 27" in the JBS/PR title because I did not update the symbol changes for build 26, and 27 was the latest I could find on https://jdk.java.net/25/
I will update this with only changes that were in that build.

It is fine if the changeset contains information from multiple builds, but I'd expect many more symbol changes for build 26 as there were approx. 250 bug fixes in that build so I wanted to check what build was intended.

There were no symbol changes in build 27.
I generated the symbol info using build 26 and updated the PR/JBS title to be accurate.
You will see that I reverted e576baf and then regenerated the symbols using build 26, but the code changes remain the same.

These are all the symbols changes for build 26, even though there were many fixes in that build.

jddarcy · 2025-06-17T16:25:07Z

src/jdk.compiler/share/data/symbols/java.base-P.sym.txt

@@ -129,6 +134,7 @@ method name powExact descriptor (II)I flags 9
 method name unsignedPowExact descriptor (II)I flags 9
 method name powExact descriptor (JI)J flags 9
 method name unsignedPowExact descriptor (JI)J flags 9
+method name cbrt descriptor (D)D flags 9 runtimeAnnotations @Ljdk/internal/vm/annotation/IntrinsicCandidate;


Presumably this is from JDK-8353686: "Optimize Math.cbrt for x86 64 bit platforms", which was also present in build 26.

This reverts commit e576baf.

The macOS/AArch64 build 26 was taken from https://jdk.java.net/25/

nizarbenalla · 2025-06-19T10:37:19Z

Thanks Joe, Iris.

/integrate

openjdk · 2025-06-19T10:38:25Z

Going to push as commit c4fb00a.
Since your change was applied there have been 44 commits pushed to the master branch:

01d4b77: 8319242: HotSpot Style Guide should discourage non-local variables with non-trivial initialization or destruction
c7125aa: 8020282: Generated code quality: redundant LEAs in the chained dereferences
0dce98b: 8359123: Misleading examples in jmod man page
... and 41 more: https://git.openjdk.org/jdk/compare/9d060574e5dbd13e634f00d749d0108ceff1fae8...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-06-19T10:38:32Z

@nizarbenalla Pushed as commit c4fb00a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Update --release 25 symbol information for JDK 25 build 27

e576baf

The macOS/AArch64 build 27 was taken from https://jdk.java.net/25/

openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025

openjdk bot added the compiler [email protected] label Jun 17, 2025

openjdk bot mentioned this pull request Jun 17, 2025

8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26 #25855

Open

3 tasks

jddarcy reviewed Jun 17, 2025

View reviewed changes

nizarbenalla added 2 commits June 18, 2025 17:11

Revert "Update --release 25 symbol information for JDK 25 build 27"

5f9a640

This reverts commit e576baf.

Update --release 25 symbol information for JDK 25 build 26

9ec49c4

The macOS/AArch64 build 26 was taken from https://jdk.java.net/25/

nizarbenalla changed the title ~~8358769: Update --release 25 symbol information for JDK 25 build 27~~ 8358769: Update --release 25 symbol information for JDK 25 build 26 Jun 18, 2025

jddarcy approved these changes Jun 18, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2025

irisclark approved these changes Jun 18, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jun 19, 2025

openjdk bot closed this Jun 19, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2025

nizarbenalla deleted the 8358769- branch June 19, 2025 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8358769: Update --release 25 symbol information for JDK 25 build 26 #25854

8358769: Update --release 25 symbol information for JDK 25 build 26 #25854

nizarbenalla commented Jun 17, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

mlbridge bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

jddarcy Jun 17, 2025

Uh oh!

nizarbenalla Jun 18, 2025

Uh oh!

jddarcy Jun 18, 2025

Uh oh!

nizarbenalla Jun 18, 2025

Uh oh!

jddarcy Jun 17, 2025

Uh oh!

nizarbenalla commented Jun 19, 2025

Uh oh!

openjdk bot commented Jun 19, 2025

Uh oh!

openjdk bot commented Jun 19, 2025

Uh oh!

Uh oh!

8358769: Update --release 25 symbol information for JDK 25 build 26 #25854

8358769: Update --release 25 symbol information for JDK 25 build 26 #25854

Conversation

nizarbenalla commented Jun 17, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

mlbridge bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

jddarcy Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

nizarbenalla Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

jddarcy Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

nizarbenalla Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

jddarcy Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

nizarbenalla commented Jun 19, 2025

Uh oh!

openjdk bot commented Jun 19, 2025

Uh oh!

openjdk bot commented Jun 19, 2025

Uh oh!

Uh oh!

nizarbenalla commented Jun 17, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 17, 2025 •

edited

Loading

mlbridge bot commented Jun 17, 2025 •

edited

Loading