8273369: Computing micros between two instants unexpectedly overflows for some cases

[rm-gh-8]

Backporting JDK-8273369: Computing micros between two instants unexpectedly overflows for some cases. Avoids overflow by not calling nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference in nano unit.

Ran GHA Sanity Checks (passed) and related test (passed).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8273369 needs maintainer approval

Issue

• JDK-8273369: Computing micros between two instants unexpectedly overflows for some cases (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4181/head:pull/4181
$ git checkout pull/4181

Update a local copy of the PR:
$ git checkout pull/4181
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4181

View PR using the GUI difftool:
$ git pr show -t 4181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4181.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (658eb7bd)
• 00: Full (52b1391b)

[rm-gh-8]

/approval request for backport of JDK-8273369: Computing micros between two instants unexpectedly overflows for some cases.

Ran the updated and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/time

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

[openjdk]

@rm-gh-8
8273369: The approval request has been created successfully.

[phohensee]

The source of the merge conflict in Instant.java is changing to a switch expression, which we don't want to do here. Please leave it as is, and patch the original switch instead.

[rm-gh-8]

Reverted switch statement.