Refactor SafeSerializationUtils for better performance#4973
Merged
cwperks merged 4 commits intoopensearch-project:mainfrom Dec 18, 2024
Merged
Refactor SafeSerializationUtils for better performance#4973cwperks merged 4 commits intoopensearch-project:mainfrom
cwperks merged 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4973 +/- ##
==========================================
- Coverage 71.48% 71.41% -0.08%
==========================================
Files 334 334
Lines 22552 22556 +4
Branches 3590 3589 -1
==========================================
- Hits 16122 16109 -13
- Misses 4639 4654 +15
- Partials 1791 1793 +2
|
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
cwperks
reviewed
Dec 16, 2024
src/test/java/org/opensearch/security/support/SafeSerializationUtilsTest.java
Show resolved
Hide resolved
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
cwperks
approved these changes
Dec 16, 2024
kumjiten
reviewed
Dec 17, 2024
src/main/java/org/opensearch/security/support/SafeSerializationUtils.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/support/SafeSerializationUtils.java
Show resolved
Hide resolved
nibix
approved these changes
Dec 18, 2024
kumjiten
approved these changes
Dec 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com> (cherry picked from commit 2f870c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Adds a cache to avoid repeated checks for same class. Removes usage of stream() in favor of a for loop
Issues Resolved
[List any issues this PR will resolve]
#4760
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
UTs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.