Skip to content

[release-4.18] OCPBUGS-62671: Add drop flows for GARP #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-62671: Add drop flows for GARP #2810

wants to merge 1 commit into from

Conversation

martinkennelly
Copy link
Contributor

while ovnkube-controller is processing.
Its removed by ovnkube-controller when processing
complete.

(cherry picked from commit 5720e33) (cherry picked from commit 22ff5c1)

@martinkennelly
Add drop flows for GARPs
c5aacca 
while ovnkube-controller is processing.
Its removed by ovnkube-controller when processing
complete.

May block for 120s until action is complete.

Signed-off-by: Martin Kennelly <[email protected]>
Signed-off-by: Periyasamy Palanisamy <[email protected]>
(cherry picked from commit 5720e33)
(cherry picked from commit 22ff5c1)
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor

@martinkennelly: This pull request references Jira Issue OCPBUGS-62671, which is invalid:

  • expected Jira Issue OCPBUGS-62671 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

while ovnkube-controller is processing.
Its removed by ovnkube-controller when processing
complete.

(cherry picked from commit 5720e33) (cherry picked from commit 22ff5c1)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from pliurh and pperiyasamy October 2, 2025 11:59
@martinkennelly martinkennelly mentioned this pull request Oct 2, 2025
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@martinkennelly: This PR was included in a payload test run from openshift/machine-config-operator#5325
trigger 10 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d396b30-9f8c-11f0-90d0-4678c9c2c425-0

@martinkennelly
Copy link
Contributor Author

/hold until qe verifys

@pliurh can you review this please since you reviewed the higher version and add the necessary labels. Its a critical bug. Clean cherry-pick. Thank you.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@martinkennelly
Copy link
Contributor Author

/retest

I saw the following disruption error on upgrade - its probably unrelated to this PR but i wanted to post it here incase we see it again:

{  backend-disruption-name/oauth-api-reused-connections connection/reused disruption/openshift-tests was unreachable during disruption:  for at least 14s (maxAllowed=10s):

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@martinkennelly: This PR was included in a payload test run from openshift/machine-config-operator#5325
trigger 10 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1434b9a0-a43f-11f0-8a2f-32c75352f1ed-0

@martinkennelly
Copy link
Contributor Author

/test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade

hit total test timeout

@jluhrsen
Copy link
Contributor

jluhrsen commented Oct 8, 2025

/retest

@pliurh
Copy link
Contributor

pliurh commented Oct 9, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkennelly, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@martinkennelly: This PR was included in a payload test run from openshift/machine-config-operator#5325
trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1a5ad180-a533-11f0-8a33-4aa5b4bdb3ee-0

@jechen0648
Copy link

/verified by 'pre-merge testing'

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 9, 2025
@openshift-ci-robot
Copy link
Contributor

@jechen0648: This PR has been marked as verified by 'pre-merge testing'.

In response to this:

/verified by 'pre-merge testing'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jluhrsen
Copy link
Contributor

jluhrsen commented Oct 9, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@jluhrsen: This PR was included in a payload test run from openshift/machine-config-operator#5325
trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da39e450-a54c-11f0-8e18-f1f75f4770a3-0

@jechen0648
Copy link

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025 •
edited
Loading

@martinkennelly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt c5aacca link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/security c5aacca link false /test security
ci/prow/e2e-openstack-ovn c5aacca link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor

pliurh commented Oct 10, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 10, 2025
@martinkennelly
Copy link
Contributor Author

CI & nightly blocking are good

@martinkennelly
Copy link
Contributor Author

/test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade

: Job run should complete before timeout expand_more

I see no test failure

@martinkennelly
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@pperiyasamy pperiyasamy Awaiting requested review from pperiyasamy

Assignees

@mffiedler mffiedler

@eurijon eurijon

@pliurh pliurh

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@imatza-rh imatza-rh

@Meina-rh Meina-rh

@barbora137 barbora137

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.