Skip to content

[release-4.18] OCPBUGS-62671: Add drop flows for GARP #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

[release-4.18] OCPBUGS-62671: Add drop flows for GARP #2810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions bindata/network/ovn-kubernetes/common/008-script-lib.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,23 @@ data:
--tls-cert-file=${clientcert}
}

# Adds drop flows for GARPs coming from patch port to br-int for fn arg bridge name.
# Remove when https://issues.redhat.com/browse/FDP-1537 lands in OVN core.
add_garp_drop_flow() {
local bridge="$1"
local cookie="0x0305"
local priority="499"
# FIXME: can we generate the exact name. Its possible we add these flows to the incorrect port when selecting on substring
for port_name in $(ovs-vsctl list-ports "$bridge"); do
if [[ "$port_name" == *to-br-int ]]; then
local of_port
of_port=$(ovs-vsctl get interface "$port_name" ofport)
ovs-ofctl add-flow "$bridge" "cookie=$cookie,table=0,priority=$priority,in_port=$of_port,arp,arp_op=1,actions=drop" > /dev/null
break
fi
done
}

# quit-nbdb() will cleanly shut down the northbound dbserver. It is intended
# to be run from a bash 'trap' like so:
#
Expand Down Expand Up @@ -490,6 +507,13 @@ data:
exit 1
fi

# start temp work around
# remove when https://issues.redhat.com/browse/FDP-1537 is available
if ovs-vsctl br-exists "br-ex"; then
add_garp_drop_flow br-ex
fi
# end temp work around

# copy the right CNI shim for the host OS
cni-bin-copy

Expand Down