-
Notifications
You must be signed in to change notification settings - Fork 257
Add /bump-k8s slash command for revendoring k8s dependencies #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add /bump-k8s slash command for revendoring k8s dependencies #2788
Conversation
This command provides a guided workflow for updating Kubernetes-related dependencies through version bumps, handling the iterative process of resolving dependency conflicts, syncing apis/go.mod, and running tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This represents several iterations, augmented as I tried to use it to do an actual revendor. I got stuck at the installer dep, which we're not ready to bump yet (no appropriate tag available) but otherwise it was working... okay. Now that I think about it, the way it was working was probably a combination of what's in the file and the context I had accumulated in that session. So before I'm ready to get serious about landing this, I should try it from scratch. Eventually we should probably look at combining this with #2783 as many of the processes and caveats are the same. Maybe a |
|
|
||
| ## Phase 3: Compile and Test | ||
|
|
||
| 11. Run `make test` to compile and run unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make verify is probably better here than make test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does verify compile and run unit tests? I agree verify would be nice to run at the end of an iteration. I think I need to clean this prompt up to get the right things "inside the loop".
This command provides a guided workflow for updating Kubernetes-related dependencies through version bumps, handling the iterative process of resolving dependency conflicts, syncing apis/go.mod, and running tests.
🤖 Generated with Claude Code