-
Notifications
You must be signed in to change notification settings - Fork 257
Add /bump-k8s slash command for revendoring k8s dependencies #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
2uasimojo
wants to merge
1
commit into
openshift:master
Choose a base branch
from
2uasimojo:ai-mandate/slash-command/bump-k8s
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| --- | ||
| description: Revendor all k8s-related dependencies to the next Y version | ||
| --- | ||
|
|
||
| Help me revendor all Kubernetes-related dependencies. Follow this workflow: | ||
|
|
||
| ## Phase 1: Identify and Update K8s Dependencies | ||
|
|
||
| 1. Read go.mod to find a known k8s dependency (like k8s.io/api) and identify its current version | ||
| 2. Extract the current Y version (e.g., if k8s.io/api is v0.33.3, current Y is "33") | ||
| 3. Determine the next Y version (e.g., from "33" to "34") | ||
| 4. Search go.mod for all k8s-related dependencies matching the current Y version | ||
| 5. For each k8s-related dependency found: | ||
| - Search for the most recent published semver tag in the **next** Y version | ||
| - Update to the latest Z version within the **next** Y version | ||
| - Note: Z versions can differ across dependencies due to interdependencies | ||
|
|
||
| 6. Iteratively run `go mod tidy` and `go mod vendor` to flush out downstream dependency issues | ||
| - **Important**: After each `go mod tidy` or any edit to go.mod, you must: | ||
| 1. Run `make modfix` (from repository root) to sync apis/go.mod | ||
| 2. `cd` into the apis/ directory and run `go mod tidy && go mod vendor` | ||
| 3. **Return to the repository root directory** (e.g., `cd /workspace`) | ||
| 4. Run `make update vendor` from the repository root | ||
| 7. If critical dependencies like openshift/installer or openshift/client-go break: | ||
| - Go to their repository | ||
| - Find a recent tagged or released commit | ||
| - Check their go.mod to see what k8s versions they require | ||
| - Adjust our versions accordingly | ||
| - **STOP** if we would need to change to a different Y version - try something different instead | ||
| - **Note**: `github.com/openshift/client-go` is forked from `k8s.io/client-go` and should match versions | ||
| - Check the `release-4.XX` branches in https://github.com/openshift/client-go | ||
| - Find a branch/commit that uses the same k8s.io/client-go version you're targeting | ||
| - Use `go get github.com/openshift/client-go@<commit-hash>` to update it | ||
|
|
||
| ## Phase 2: Sync apis/go.mod | ||
|
|
||
| 8. Once the root go.mod dependency graph is stable, run `make modfix` to sync apis/go.mod | ||
| 9. Run `go mod tidy` and `go mod vendor` in the apis/ directory | ||
| 10. Return to the repository root directory and run `make update vendor` | ||
|
|
||
| ## Phase 3: Compile and Test | ||
|
|
||
| 11. Run `make test` to compile and run unit tests | ||
| 12. If compilation errors occur, fix them. Common issues: | ||
| - Deprecated functions/symbols removed - update to recommended replacements | ||
| - Function signatures changed (params added/removed) - accommodate changes | ||
| 13. Keep iterating until `make test` succeeds | ||
|
|
||
| ## Phase 4: Commit | ||
|
|
||
| 14. When all tests pass, commit the changes | ||
|
|
||
| **Important**: If you get stuck at any point, stop and ask for help rather than trying to commit broken code. | ||
|
|
||
| Track your progress with the TodoWrite tool and work through each phase methodically. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make verifyis probably better here thanmake testThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
verifycompile and run unit tests? I agreeverifywould be nice to run at the end of an iteration. I think I need to clean this prompt up to get the right things "inside the loop".