OCPBUGS-48403: Bring groupsnapshot beta feature to 4.18 #2169
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@jsafrane: This pull request references STOR-2135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@jsafrane: This pull request references STOR-2135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jsafrane
changed the title
|
@jsafrane: This pull request references Jira Issue OCPBUGS-48403, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/retest |
|
/test help |
|
@jsafrane: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add images required by openshift/kubernetes#2169.
|
@jsafrane: This PR was included in a payload test run from openshift/origin#29455
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14c69e80-d7dd-11ef-81a4-277ec891544d-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm |
|
@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3a789520-d7dd-11ef-8f7d-a0d037a5b880-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm openshift/origin#29455 |
|
@jsafrane: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get additional pr info from string: run: string: run doesn't match expected format: org/repo#number
Please contact an administrator to resolve this issue. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm openshift/origin#29455 And run it again with the origin PR to see the images are mirrored now |
|
@jsafrane: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get additional pr info from string: And: string: And doesn't match expected format: org/repo#number
Please contact an administrator to resolve this issue. |
|
/retest |
Add images required by openshift/kubernetes#2169.
openshift-ci
bot
added
the
approved
|
/hold We need openshift/origin#29455 before merging this, otherwise metal jobs will get broken. |
openshift-ci
bot
assigned gangwgr, kasturinarra, wangke19, xingxingxia and zhouying7780
|
/retest-required |
|
I can see a baremetal job that mirrors its images succeeded: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-kubernetes-2169-nightly-4.18-e2e-metal-ipi-ovn-bm/1882350627531526144 (e2e script logs with mirroring here) So when it comes to image mirroring, this is ready for merge. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, gnufied, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/validate-backports |
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
removed
the
backports/unvalidated-commits
openshift-merge-bot
bot
merged commit 7665f4b
into
openshift:release-4.18
|
@jsafrane: Jira Issue OCPBUGS-48403: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-48403 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This reverts commit 79b7a63. Add images required by openshift/kubernetes#2169.
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
This reverts commit 79b7a63. Add images required by openshift/kubernetes#2169.
Backport volume group snapshot tests to OCP 4.18.
There is oneThe carry patch has been removed, it breaks other tests. So this just brings a new test + marks it as<carry>patch that enables volume group feature gate in a test manifest by default, because that's our goal in 4.18 - have the feature enabled by default.[Disabled:Alpha]. We will solve it differently.Corresponding 4.19 PR: #2155