OCPBUGS-48403: Bring groupsnapshot beta feature to 4.18 #29427
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jsafrane: This pull request references STOR-2135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jsafrane
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@jsafrane: This pull request references STOR-2135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jsafrane
changed the title
|
@jsafrane: This pull request references Jira Issue OCPBUGS-48403, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
jsafrane
force-pushed
the
4.18-add-groupsnapshot-real
branch
from
11817fb to
65c585b
Compare
jsafrane
force-pushed
the
4.18-add-groupsnapshot-real
branch
2 times, most recently
from
242e09d to
b9fe31c
Compare
|
@jsafrane: This pull request references Jira Issue OCPBUGS-48403, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
||
| // VAC E2E FeatureGate patches | ||
| // TODO: These can be removed after the VolumeAttributesClass feature is default enabled | ||
| patches = append(patches, utils.PatchCSIOptions{ |
There was a problem hiding this comment.
Why are we enabling VAC features also btw?
There was a problem hiding this comment.
That's enabled in the original csi-hostpath driver, I just copied it.
|
/test e2e-aws-csi |
jsafrane
force-pushed
the
4.18-add-groupsnapshot-real
branch
from
2c82be0 to
b632449
Compare
jsafrane
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@jsafrane: This pull request references Jira Issue OCPBUGS-48403, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jsafrane
force-pushed
the
4.18-add-groupsnapshot-real
branch
from
b632449 to
4bd2b5a
Compare
|
/retest |
|
/test e2e-metal-ipi-ovn |
|
/test images |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/hold Revision 4bd2b5a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
The tests need deployment of csi-driver-hostpath with enabled group snapshots. Upstream uses a script, which cannot be used in OCP. We replace the script with a code that copies upstream csi-hostpath test driver as "csi-hostpath-groupsnapshot" that run the driver with group snapshots enabled.
This reverts commit 79b7a63. Add images required by openshift/kubernetes#2169.
jsafrane
force-pushed
the
4.18-add-groupsnapshot-real
branch
from
4bd2b5a to
af0a655
Compare
|
Updated with openshift/kubernetes#2185 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview |
|
@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f7e4720-dfe9-11ef-9310-49082eba2663-0 |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 1662021
into
openshift:release-4.18
|
@jsafrane: Jira Issue OCPBUGS-48403: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-48403 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Bump openshift/kubernetes from OCPBUGS-48403: Bring groupsnapshot beta feature to 4.18 kubernetes#2169.
Add a new test driver
[Driver: csi-hostpath-groupsnapshot]that runs the csi-driver-hostpath with group snapshots enabled. It is mostly a copy of the original test driver fromvendor/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi.go. This code should be removed when the feature gate is enabled in OCP and we can therefore enable it in the default[Driver: csi-hostpath]test driver../openshift-tests run all --run="Driver: csi-hostpath-groupsnapshot.*Feature:volumegroupsnapshot". A CI job will follow.This also reverts OCPBUGS-48403: Add new images for group snapshot support #29455, the images should be populated from kubernetes manifests now.