OCPBUGS-48403: Bring groupsnapshot beta feature to 4.18 #171
Conversation
Use protobuf encoding for core K8s APIs in external-snapshotter
test: fix trivy github action error
Fix typo in error message message
…tlist Add and set the new VolumeSnapshotHandlePairList field
this commit adds new parameter keys for getvolumegroupsnapshot Signed-off-by: yati1998 <[email protected]>
Bumps the github-dependencies group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) | `1.7.0` | `1.8.0` | | [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | `1.20.2` | `1.20.5` | | [github.com/prometheus/common](https://github.com/prometheus/common) | `0.55.0` | `0.60.1` | | [google.golang.org/grpc](https://github.com/grpc/grpc-go) | `1.65.0` | `1.67.1` | | google.golang.org/protobuf | `1.34.2` | `1.35.1` | | [github.com/klauspost/compress](https://github.com/klauspost/compress) | `1.17.9` | `1.17.11` | | [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) | `0.54.0` | `0.56.0` | | [golang.org/x/time](https://github.com/golang/time) | `0.6.0` | `0.7.0` | Updates `github.com/fsnotify/fsnotify` from 1.7.0 to 1.8.0 - [Release notes](https://github.com/fsnotify/fsnotify/releases) - [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md) - [Commits](fsnotify/fsnotify@v1.7.0...v1.8.0) Updates `github.com/prometheus/client_golang` from 1.20.2 to 1.20.5 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.5) Updates `github.com/prometheus/common` from 0.55.0 to 0.60.1 - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.55.0...v0.60.1) Updates `google.golang.org/grpc` from 1.65.0 to 1.67.1 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.65.0...v1.67.1) Updates `google.golang.org/protobuf` from 1.34.2 to 1.35.1 Updates `github.com/klauspost/compress` from 1.17.9 to 1.17.11 - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](klauspost/compress@v1.17.9...v1.17.11) Updates `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` from 0.54.0 to 0.56.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.54.0...zpages/v0.56.0) Updates `go.opentelemetry.io/otel` from 1.29.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0) Updates `go.opentelemetry.io/otel/metric` from 1.29.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0) Updates `go.opentelemetry.io/otel/trace` from 1.29.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0) Updates `golang.org/x/net` from 0.28.0 to 0.30.0 - [Commits](golang/net@v0.28.0...v0.30.0) Updates `golang.org/x/oauth2` from 0.22.0 to 0.23.0 - [Commits](golang/oauth2@v0.22.0...v0.23.0) Updates `golang.org/x/sys` from 0.24.0 to 0.26.0 - [Commits](golang/sys@v0.24.0...v0.26.0) Updates `golang.org/x/term` from 0.23.0 to 0.25.0 - [Commits](golang/term@v0.23.0...v0.25.0) Updates `golang.org/x/text` from 0.17.0 to 0.19.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.17.0...v0.19.0) Updates `golang.org/x/time` from 0.6.0 to 0.7.0 - [Commits](golang/time@v0.6.0...v0.7.0) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20240822170219-fc7c04adadcd to 0.0.0-20241007155032-5fefd90f89a9 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/fsnotify/fsnotify dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/klauspost/compress dependency-type: indirect update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/otel dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/otel/metric dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/otel/trace dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/oauth2 dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/sys dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/term dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/text dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/time dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-type: indirect update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…/go_modules/github-dependencies-24b967fb58 Bump the github-dependencies group across 1 directory with 17 updates
…hot-controller Previously, the csi-snapshotter was responsible for creating individual VolumeSnapshots and VolumeSnapshotContents for each member when dynamically provisioning a VolumeGroupSnapshot. This commit relocates this logic to the snapshot-controller, bringing all resource creation processes under a single authority.
this commit updates csi spec version to include latest changes for volume group snapshot Signed-off-by: yati1998 <[email protected]>
Update CSI Spec
Centralize VolumeGroupSnapshot members resource creation in the snapshot-controller
…oupSnapshotRef_check Remove volumeGroupSnapshotRef immutable validation rule
This patch sets the `spec.persistentVolumeClaimName` field for volume snapshots that are member of a dynamically provisioned volume group snapshot, like a dynamically provisioned volume snapshot would do. The volume snapshot logic has been improved to skip the creation of relative snapshot as it has already been created by the group snapshot.
test: fix trivy action
Set PVC name on VolumeGroupSnapshot members
Add PV informer and indexer
Add secrets for Get VolumeGroupSnapshot
this commit includes feature gate method to enable the volumeGroupSnapshot Signed-off-by: yati1998 <[email protected]>
…TODO Pass context on in GroupSnapshot sync functions
…esnapshotcontentlist Remove PVVolumeSnapshotContentList field from the VolumeGroupSnapshotContentStatus API
|
This will also need openshift/cluster-csi-snapshot-controller-operator#224. Currently it is trying to start webhook controller and failing. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/retest |
|
/retest |
|
@gnufied: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/test periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview |
|
@gnufied: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview |
|
@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3c18f6f0-d525-11ef-925d-99ef79bd95ff-0 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-upgrade |
|
@gnufied: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 0332c00
into
openshift:release-4.18
|
@gnufied: Jira Issue OCPBUGS-48403: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-48403 has not been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-csi-external-snapshotter |
|
[ART PR BUILD NOTIFIER] Distgit: ose-csi-snapshot-controller |
|
[ART PR BUILD NOTIFIER] Distgit: csi-snapshot-validation-webhook |
No description provided.