Skip to content

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Dec 3, 2025

While helpful in the happy path, the reality is that many regressions come and go on the board over time. We treat regressions as release blockers, but when they drop off the board the case gets murkier to push for a fix and prevent it the next time. This message appearing on such bugs immediately triggers ambiguity and debate with engineering about whether or not the issue should be fixed, which burns time and when unsuccessful leaves us exposed to the whole cycle repeating again later when the unfixed issue returns.

I would argue we're better off making it harder to notice this, and letting eng teams work through the fixes regardless rather than reopening the debate.

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Removed Jira notifications that were being sent when triages are resolved. The triage resolution process continues to function normally without posting status updates to Jira.

✏️ Tip: You can customize this high-level summary in your review settings.

This is leading to increased debate rather than focus on fixes, as
things can and do come and go on the board.
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'tools'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The pull request removes Jira integration logic for reporting resolved triages. Specifically, it deletes the function call to ReportTriageResolved from the ResolveTriages function and removes the ReportTriageResolved function definition entirely, eliminating Jira comment posting for triage resolutions.

Changes

Cohort / Cohort Title Summary
Jira reporting removal
pkg/api/componentreadiness/regressiontracker.go, pkg/api/componentreadiness/triage.go
Removed the ReportTriageResolved function call from the ResolveTriages method and deleted the exported ReportTriageResolved function that posted "resolved" status messages to Jira. Triage resolution logging continues unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify no other code references the removed ReportTriageResolved function
  • Confirm removal is intentional and no alternative Jira reporting mechanism replaces this functionality

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Go Error Handling ❓ Inconclusive Analysis cannot be completed due to persistent repository access failures preventing examination of actual code changes in modified files. Resolve repository access issues to manually review modified files for proper error handling in Jira operations and verify no error returns are being ignored.
Sql Injection Prevention ❓ Inconclusive Repository could not be accessed to perform comprehensive code analysis due to cloning failures in sandbox environment. Unable to definitively verify SQL injection vulnerabilities without direct access to modified code files. Provide direct access to modified code files from regressiontracker.go and triage.go or ensure repository is accessible in analysis environment.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing Jira status updates when regressions resolve, which aligns with removed ReportTriageResolved calls and the exported function.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Excessive Css In React Should Use Styles ✅ Passed PR modifies Go backend files to remove Jira reporting for regression resolution; contains no React, JSX, TypeScript, or CSS code, so the custom check for inline CSS in React components is not applicable.
Single Responsibility And Clear Naming ✅ Passed PR improves Single Responsibility by removing dual responsibilities from ResolveTriages, decoupling triage resolution from Jira reporting while maintaining clear, action-oriented naming.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants