Skip to content

Stop updating triaged Jiras when all regressions resolve #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgoodwin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop updating triaged Jiras when all regressions resolve #3139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/api/componentreadiness/regressiontracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ func (prs *PostgresRegressionStore) ResolveTriages() error {
continue
}

ReportTriageResolved(prs.jiraClient, triage)
log.Infof("Resolved triage %d with resolution time %v", triage.ID, triage.Resolved.Time)
}

Expand Down
7 changes: 0 additions & 7 deletions pkg/api/componentreadiness/triage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,6 @@ func CreateTriage(dbc *gorm.DB, jiraClient *jira.Client, triage models.Triage, r

const jiraPrefix = "https://issues.redhat.com/browse/"

// ReportTriageResolved comments on the associated jira that the regressions have been resolved, including a link
// to the triage details
func ReportTriageResolved(jiraClient *jira.Client, triage models.Triage) {
message := "All regressions associated with this triage record have been resolved."
reportOnJiraUsedForTriage(jiraClient, triage, message, nil)
}

// ReportTriageAddedForJira comments on the associated jira with a link to the triage details
func ReportTriageAddedForJira(jiraClient *jira.Client, triage models.Triage, req *http.Request) {
message := "This bug has been triaged to one or more component readiness regressions."
Expand Down