-
Notifications
You must be signed in to change notification settings - Fork 403
Fixed Highlight Feature #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Highlight Feature #791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
@Harsh-26626 please review this PR |
2025-08-20.23-39-05.mp4The implementation is not upto mark. Lots of inconsistencies. Cannot switch back not normal color if we highlight text once. check shared video for reference. take more time if you want but kindly consider improving the current implementation:) |
|
@Harsh-26626 I'll work on this.. actually in this implementation I focused on highlighting selected text only and not highlighting while typing hence it didn't work but I'll work on this as this would be helpful for users. |
|
@Harsh-26626 Please review this updated PR. I have fixed all inconsistencies and tested it as you can see in the video attached but still if there is anything left please let me know. Also wanted to let you know that I can see gssoc label along with osci (but I am only an OSCI contributor) |
Added missing closing tag for editor-wrapper
Related Issues
Fixes #743, #771 and #780
Changes Made
Demo Video:
bandicam.2025-08-22.06-56-52-498.mp4