Skip to content

Conversation

@ApurvaNair
Copy link
Contributor

@ApurvaNair ApurvaNair commented Aug 20, 2025

Related Issues

Fixes #743, #771 and #780

Changes Made

  • Removed Bookmark feature
  • Fixed highlight feature:
    • Preserved highlights when pdf is downloaded
  • Addressed related issue [Bug] Drawing color cannot be changed in jotpad (locked to theme colors) #780 (highlight not working correctly)
    • Able to draw using selected color
    • Default (black color for light mode and white color for dark mode)
  • Highlight while typing by first turning on highlight button
  • Once it is turned off no highlight will be visible

Demo Video:

bandicam.2025-08-22.06-56-52-498.mp4

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@ApurvaNair
Copy link
Contributor Author

@Harsh-26626 please review this PR

@OpArcade OpArcade added level 1 Beginner-level issue 2⭐⭐ Moderate task, needs some coding knowledge and problem-solving skills. enhancement New feature or request gssoc2025 This issue is part of GirlScript Summer of Code 2025 OSCI'25 Open Source Connect India labels Aug 20, 2025
@Harsh-26626
Copy link
Collaborator

2025-08-20.23-39-05.mp4

The implementation is not upto mark. Lots of inconsistencies. Cannot switch back not normal color if we highlight text once. check shared video for reference.

take more time if you want but kindly consider improving the current implementation:)

@ApurvaNair
Copy link
Contributor Author

@Harsh-26626 I'll work on this.. actually in this implementation I focused on highlighting selected text only and not highlighting while typing hence it didn't work but I'll work on this as this would be helpful for users.
Thank you for the feedback!

@ApurvaNair
Copy link
Contributor Author

ApurvaNair commented Aug 22, 2025

@Harsh-26626 Please review this updated PR. I have fixed all inconsistencies and tested it as you can see in the video attached but still if there is anything left please let me know. Also wanted to let you know that I can see gssoc label along with osci (but I am only an OSCI contributor)

Added missing closing tag for editor-wrapper
@Harsh-26626 Harsh-26626 merged commit 0dbb7e8 into opensource-society:master Aug 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2⭐⭐ Moderate task, needs some coding knowledge and problem-solving skills. enhancement New feature or request gssoc2025 This issue is part of GirlScript Summer of Code 2025 level 1 Beginner-level issue OSCI'25 Open Source Connect India

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants