-
Notifications
You must be signed in to change notification settings - Fork 138
[update] Allow curl to use ipv6 for downloading cirros image. #3329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For testing we use a cirros image that is used to create a vm on the cloud. We used to force ipv4 on curl, but it fails in ipv6 unidelta job. Remove the constraint to suit ipv4 and ipv6 jobs. Closes: [uni04delta-ipv6-update failing to download cirros-cloud.net image ](https://issues.redhat.com/browse/OSPRH-17249)
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arxcruz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sathlan just FTR, in crc-cloud/nested crc jobs, we set that it should prefer ipv4 over ipv6 |
if [ $? -ne 0 ]; then | ||
echo "Downloading image ${IMAGE_URL}" | ||
curl -4fsSLk --retry 5 -o ${IMAGE_FILE} ${IMAGE_URL} | ||
curl -fsSLk --retry 5 -o ${IMAGE_FILE} ${IMAGE_URL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: normally suggest if using ping6 -w1 -c1
to opendev or somewhere else
dig AAAA opendev.org +short
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you have in mind? Is there something that could be improved or changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danpawlik suggests to ping opendev and get output in advance to understand what TCP protocol is used. TCPv4 or TCPv6. otherwise the issue is hidden by "-s" flag of curl. In this case "-S" flag doesn't help too much
Thank you for follow-up and resolving the problem in a way I originally also had in mind. |
For testing we use a cirros image that is used to create a vm on the
cloud.
We used to force ipv4 on curl, but it fails in ipv6 unidelta job.
Remove the constraint to suit ipv4 and ipv6 jobs.
Closes: uni04delta-ipv6-update failing to download cirros-cloud.net image