Skip to content

[update] Allow curl to use ipv6 for downloading cirros image. #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[update] Allow curl to use ipv6 for downloading cirros image. #3329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/update/templates/workload_launch.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ function workload_launch {
openstack image list | grep ${IMAGE_NAME}
if [ $? -ne 0 ]; then
echo "Downloading image ${IMAGE_URL}"
curl -4fsSLk --retry 5 -o ${IMAGE_FILE} ${IMAGE_URL}
curl -fsSLk --retry 5 -o ${IMAGE_FILE} ${IMAGE_URL}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: normally suggest if using ping6 -w1 -c1 to opendev or somewhere else
dig AAAA opendev.org +short

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you have in mind? Is there something that could be improved or changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danpawlik suggests to ping opendev and get output in advance to understand what TCP protocol is used. TCPv4 or TCPv6. otherwise the issue is hidden by "-s" flag of curl. In this case "-S" flag doesn't help too much


if [ $? -ne 0 ]; then
echo "Failed to download ${IMAGE_URL}"
Expand Down