fix: reflect correct return types for get_delegated #3016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewhaleking
previously approved these changes
Aug 15, 2025
Closed
|
Will rerun tests and merge after #3020 is merged |
|
pls merge staging |
Arthurdw
force-pushed
the
PATCH-reflect-correct-types-for-get_delegated
branch
from
6a648c6 to
ad9aa79
Compare
|
Not sure why these e2e's are failing? (I don't believe my changes should have any impact on them) |
In your codebase, commit reveal test still used get_current_weight_commit_info_v2 method instead of new one in our staging. |
thewhaleking
approved these changes
Aug 24, 2025
This was referenced Aug 28, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
DelegatedInfo.list_from_dictsreturns a list ofDelegatedInfonottuple[DelegatedInfo, Balance]; this pr fixes the type hints for this.Release Notes
N/A
Branch Acknowledgement
staging