-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ADR with actions decided upon during the OTP summit in Helsinki #6866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jessicaKoehnke
merged 4 commits into
opentripplanner:dev-2.x
from
HBTGmbH:adr-developer-meeting
Oct 6, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ede76b6
create ADR with actions decided upon during the OTP summit in Helsinki.
jessicaKoehnke c8f12b2
Update doc/dev/decisionrecords/StreamliningDevProcess.md
jessicaKoehnke e81765c
Update doc/dev/decisionrecords/StreamliningDevProcess.md
jessicaKoehnke 4e620f3
small updates
jessicaKoehnke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Development Process Conventions | ||
|
|
||
| | Date | People attending | Status | | ||
| |------------|--------------------|---------| | ||
| | 18.09.2025 | developer workshop | decided | | ||
|
|
||
|
|
||
| We need guidelines for the development process in general and the dev meeting in particular that enable us to better keep up with the increasing amount or pull requests. This list was agreed upon by the developers attending the OTP Summit in Helsinki in September 2025. | ||
|
|
||
VillePihlava marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ### Context and Problem Statement | ||
|
|
||
| Core developers experience an increasing workload doing reviews so that they don't find enough time for development themselves. The decisions made here aim to | ||
| - increase the quality of the PRs by catching potential problems early | ||
| - make dev-meetings more effective to potentially save time | ||
|
|
||
|
|
||
| ### Decision and Consequences | ||
VillePihlava marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| The following list of actions are agreed upon by all attending developers. We will revisit this list in February 2026 to decide, if further actions are needed. | ||
VillePihlava marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| #### 1. Time boxing discussions in dev-meetings | ||
| To avoid getting into detailed discussions that don't really lead anywhere, discussions in the dev meeting will be time boxed. If time is up, it will be decided if the discussion is beneficial to all people present and should be continued, or if the discussion should be continued in another manner. This could for example mean | ||
| - scheduling a design meeting | ||
| - specific people doing more research | ||
| - tabling the discussion for a later dev-meeting when people have had time to think about the problem more and/or when other key people are present | ||
|
|
||
| Time boxes: | ||
| - Agenda Item: 10 minutes | ||
| - PR: 5 minutes | ||
|
|
||
| Additionally, **no debugging** should be done in dev-meetings. | ||
|
|
||
|
|
||
| #### 2. Only discuss PRs in dev-meetings if owner of PR is present | ||
| The author of the PR should be present to answer any questions and/or present their implementation. Exceptions to this rule are possible, for example when there are time zone constraints. Questions that are supposed to be discussed in the dev-meeting without the author being present should be outlined in a comment on the PR. | ||
|
|
||
| #### 3. Only discuss draft PRs and issues in dev-meeting if they are on the agenda | ||
| To save time, we do not want to go through every issue and draft PR every dev-meeting. If a discussion on a specific draft PR or issue is needed, then it should be put onto the agenda. | ||
|
|
||
| #### 4. Use threads in gitter | ||
| To avoid clutter in our Gitter channel, always use threads. Messages not abiding by this rule will be deleted. | ||
|
|
||
| #### 5. Decide *early* if we want to invest resources into a PR made by non-core developers | ||
| All PRs made by non-core developers lead to the core developers having to spend resources on reviewing the code and potentially having to provide guidance to the author. We need to decide early, if the PR will be beneficial to enough contributors that investing these resources is worth it. This is especially important for PRs that will touch the core. | ||
|
|
||
| Product Owners should have the ultimate decision in this. That way the core developers will have the official backing of their employers and have fewer conflicts investing their time. | ||
|
|
||
| #### 6. Issues not made by regular contributors will have to be categorized by adding a label | ||
|
|
||
| To be able to deal with issues efficiently, issues will have to be categorized. Markus will go through new issues: | ||
| 1. Close it if it is not a requested change to OTP | ||
| 2. Assign one of the following labels: | ||
| - `Bug` | ||
| - `Documentation` | ||
| - `Improvement` | ||
| - `New Feature` | ||
| - `Optimization` | ||
| - `Technical Debt` | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.