-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ADR with actions decided upon during the OTP summit in Helsinki #6866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR with actions decided upon during the OTP summit in Helsinki #6866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6866 +/- ##
==========================================
Coverage 72.10% 72.11%
- Complexity 19526 19530 +4
==========================================
Files 2106 2106
Lines 78982 78982
Branches 8007 8007
==========================================
+ Hits 56952 56955 +3
+ Misses 19205 19203 -2
+ Partials 2825 2824 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the title to DevelopmentProcessConventions
|
Once the updates to the contribution guidelines in PR #6869 have been merged, this decision should be referenced in |
|
I agree with Ville's suggested renaming. Otherwise, this looks like a nice summary - thanks! |
Co-authored-by: Thomas Gran <[email protected]>
Co-authored-by: Thomas Gran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attendance record isn't that important anymore now that everyone is on the same page and everyone seems to agree.
I think you can remove most of the metatext, because this should be concise and we just want the decisions. The context and problem statement is enough context in my opinion. The date for the review should be entered into the calendar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the PR as is, I added a few comments on minor issues. Some context information is useful - e.g. for a new developer reading this in 5 years from now.
This documents the decisions we made at the developer meeting during the OTP Summit in Helsinki