Skip to content

Conversation

@jessicaKoehnke
Copy link
Contributor

This documents the decisions we made at the developer meeting during the OTP Summit in Helsinki

Copy link
Contributor

@henrik242 henrik242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.11%. Comparing base (774bae4) to head (ede76b6).
⚠️ Report is 38 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6866   +/-   ##
==========================================
  Coverage      72.10%   72.11%           
- Complexity     19526    19530    +4     
==========================================
  Files           2106     2106           
  Lines          78982    78982           
  Branches        8007     8007           
==========================================
+ Hits           56952    56955    +3     
+ Misses         19205    19203    -2     
+ Partials        2825     2824    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@VillePihlava VillePihlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title to DevelopmentProcessConventions

@VillePihlava
Copy link
Contributor

Once the updates to the contribution guidelines in PR #6869 have been merged, this decision should be referenced in CONTRIBUTING.md

@leonardehrenfried
Copy link
Member

I agree with Ville's suggested renaming. Otherwise, this looks like a nice summary - thanks!

@leonardehrenfried leonardehrenfried added +Skip Changelog This is not a relevant change for a product owner since last release. +Developer Decision Record PR with a Developer Decision Record labels Sep 23, 2025
@jessicaKoehnke jessicaKoehnke marked this pull request as ready for review September 25, 2025 14:44
@jessicaKoehnke jessicaKoehnke requested a review from a team as a code owner September 25, 2025 14:44
Copy link
Contributor

@VillePihlava VillePihlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attendance record isn't that important anymore now that everyone is on the same page and everyone seems to agree.

I think you can remove most of the metatext, because this should be concise and we just want the decisions. The context and problem statement is enough context in my opinion. The date for the review should be entered into the calendar.

Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the PR as is, I added a few comments on minor issues. Some context information is useful - e.g. for a new developer reading this in 5 years from now.

@jessicaKoehnke jessicaKoehnke merged commit 0e945f9 into opentripplanner:dev-2.x Oct 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Developer Decision Record PR with a Developer Decision Record +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants