Skip to content

Conversation

@VillePihlava
Copy link
Contributor

Summary

This PR updates the contributing guidelines as discussed in the September 2025 OTP Summit in Helsinki.

Issue

N/A

Unit tests

N/A

Documentation

  • CONTRIBUTING.md
  • README.md
  • .github/pull_request_template.md

@VillePihlava VillePihlava requested a review from a team as a code owner September 18, 2025 13:02
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.10%. Comparing base (0e945f9) to head (b18674c).
⚠️ Report is 20 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6869      +/-   ##
=============================================
- Coverage      72.10%   72.10%   -0.01%     
+ Complexity     19671    19669       -2     
=============================================
  Files           2125     2125              
  Lines          79533    79533              
  Branches        8051     8051              
=============================================
- Hits           57349    57345       -4     
- Misses         19347    19349       +2     
- Partials        2837     2839       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VillePihlava
Copy link
Contributor Author

The decisions from PR #6866 will have to be referenced in CONTRIBUTING.md once it has been merged

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicely written and adds much more needed clarity to the expectations for how issues and PRs will be dealt with going forward.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you take a look at Binh's comments, I'm happy to review this.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you take a look at Binh's comments, I'm happy to review this.

@optionsome optionsome added the !Documentation Improve documentation targeting users and/or developers. label Sep 30, 2025
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not count as a review, but I will file a few suggestions.

In general consider to format the document using 100 characters long lines. This is mainly to make it easy to read in the "source" view.

@VillePihlava VillePihlava merged commit 3ec87bc into opentripplanner:dev-2.x Oct 7, 2025
8 checks passed
t2gran pushed a commit that referenced this pull request Oct 7, 2025
@VillePihlava VillePihlava deleted the contributing-doc-changes branch October 7, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Documentation Improve documentation targeting users and/or developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants