[GPU] Allocate output mem using virtual memory in Windows even if physical memory is full #30106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isanghao
reviewed
Apr 14, 2025
| @@ -165,7 +165,6 @@ bool ocl_engine::check_allocatable(const layout& layout, allocation_type type) { | |||
| GPU_DEBUG_COUT << "[Warning] [GPU] Exceeded max size of memory allocation: " << "Required " << layout.bytes_count() << " bytes, already occupied : " | |||
| << used_mem << " bytes, but available memory size is " << get_max_memory_size() << " bytes" << std::endl; | |||
| GPU_DEBUG_COUT << "Please note that performance might drop due to memory swap." << std::endl; | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
random spot) could you check additional assertion whether the primitive has output buffer when executed? this would be helpful for future troubleshoot of such issue.
There was a problem hiding this comment.
Added assertions at set_arguments_impl() which allocated memory is necessary
isanghao
reviewed
Apr 14, 2025
| @@ -165,7 +165,6 @@ bool ocl_engine::check_allocatable(const layout& layout, allocation_type type) { | |||
| GPU_DEBUG_COUT << "[Warning] [GPU] Exceeded max size of memory allocation: " << "Required " << layout.bytes_count() << " bytes, already occupied : " | |||
| << used_mem << " bytes, but available memory size is " << get_max_memory_size() << " bytes" << std::endl; | |||
| GPU_DEBUG_COUT << "Please note that performance might drop due to memory swap." << std::endl; | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
random spot) PR title is difficult to understand. Could you rewrite it to express what it is doing or why it matters?
There was a problem hiding this comment.
Updated PR title
kelvinchoi-intel
force-pushed
the
enable_faster_rcnn_nas_lowproposals_coco
branch
from
bd7fc73 to
9e045ae
Compare
kelvinchoi-intel
changed the title
kelvinchoi-intel
changed the title
kelvinchoi-intel
force-pushed
the
enable_faster_rcnn_nas_lowproposals_coco
branch
2 times, most recently
from
7089381 to
3de6c74
Compare
hyunback
approved these changes
Apr 15, 2025
isanghao
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: