Fix a "format order" regression from the autodep branch #5864
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're sorting the format list in struct name order, but we want the OpenCL formats last in the list. Closes openwall#5863
magnumripper
force-pushed
the
autodep-order-regression
branch
from
8b84399 to
d2d962b
Compare
|
Thank you for noticing this issue and fixing it. Why exactly do you also add |
It's for the academical case of no plugins present. The cpp commands will error on "no input files" and without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're sorting the format list in struct name order, but we want the OpenCL formats last in the list.
Closes #5863